Check return codes everywhere

[Markus Elfring]

Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "​strdup" like in the member function "Host::parseMountTable​" and from "​fprintf" in the function "xpidl_write_comment​"?

[Klaus Espenlaub]

Since the report is about a very fuzzy topic, I've squeezed as much constructive criticism out of it as possible and added the reported strdup issue to the todo list.

I see very little value in fixing third-party code which is used to build VirtualBox. If that fails due to out of disk space situations this will not go unnoticed.

[Markus Elfring]

Replying to klaus:

I suggest to avoid unchecked function calls.
Would you like to detect every error situation as early as possible?

[Klaus Espenlaub]

The strdup issue is fixed in SVN.

[Markus Elfring]

Would you like to complete the error detection and corresponding exception handling also for function calls like "fprintf"?

[Klaus Espenlaub]

I already explained that I see no value in fixing this third-party code which is used to _build_ VirtualBox. If we'd fix code from the Mozilla project what would be left for them to do? :)

[Markus Elfring]

Replying to klaus:

Would you like to forward this open issue to the other software project?

[Markus Elfring]

How do you think about to check if a function call like "fclose​" failed?

[Sander van Leeuwen]

As you take great pleasure in notifying others about significant flaws in their code, I think it would be best if you took it upon yourself to inform 3rd parties.

[Markus Elfring]

Would you like to care for failed close()​ and malloc()​ calls in your own source files?

[Klaus Espenlaub]

This is no bug report.

[Markus Elfring]

Replying to klaus:

Why not?

I interpret it as a programming error to ignore return values from function calls that I pointed out.