[vbox-dev] [PATCH] Fix for bug #21516

[Alexander Eichner]

Hi Peter,

Thanks for the patch. We fixed the issue internally, albeit a bit differently.

Regards,
Alexander Eichner

On 11.08.2023 23:36, Peter Palúch via vbox-dev <vbox-dev at virtualbox.org> wrote:

Greetings,

Attaching a patch fixing the bug #21516<https://www.virtualbox.org/ticket/21516> (Cisco CSR 1000v and 8000v does not recognize interfaces).

It turns out that in src/VBox/Devices/Network/DevVirtioNet.cpp, the macro PCI_CLASS_BASE_NETWORK_CONTROLLER was set to 0x0200 (0x02 =PCI Network Device Class ID, 0x00 = Ethernet subclass). However, this macro is passed to another macro, PDMPciDevSetClassBase, that expects uint8_t as the PCI device class value. This has caused the virtio-net PCI adapter to be reported with the PCI class/subclass 0x0000, confusing some host operating systems.

The fix is trivial - set PCI_CLASS_BASE_NETWORK_CONTROLLER to 0x02 instead of 0x0200.

Please consider integrating this fix at your earliest convenience.

Thank you!

Best regards,
Peter
<virtionet-21516.patch>_______________________________________________
vbox-dev mailing list
vbox-dev at virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.virtualbox.org/pipermail/vbox-dev/attachments/20230814/23517d0f/attachment.html>