<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;">
Hi Peter,
<div><br>
</div>
<div>Thanks for the patch. We fixed the issue internally, albeit a bit differently.</div>
<div><br>
</div>
<div>Regards,</div>
<div>Alexander Eichner<br>
<div><br>
<blockquote type="cite">
<div>On 11.08.2023 23:36, Peter Palúch via vbox-dev <vbox-dev@virtualbox.org> wrote:</div>
<br class="Apple-interchange-newline">
<div>
<div dir="ltr">
<div>Greetings,</div>
<div><br>
</div>
<div>Attaching a patch fixing the bug <a href="https://www.virtualbox.org/ticket/21516">
#21516</a> (Cisco CSR 1000v and 8000v does not recognize interfaces).</div>
<div><br>
</div>
<div>It turns out that in src/VBox/Devices/Network/DevVirtioNet.cpp, the macro PCI_CLASS_BASE_NETWORK_CONTROLLER was set to 0x0200 (0x02 =PCI Network Device Class ID, 0x00 = Ethernet subclass). However, this macro is passed to another macro, PDMPciDevSetClassBase,
that expects uint8_t as the PCI device class value. This has caused the virtio-net PCI adapter to be reported with the PCI class/subclass 0x0000, confusing some host operating systems.</div>
<div><br>
</div>
<div>The fix is trivial - set PCI_CLASS_BASE_NETWORK_CONTROLLER to 0x02 instead of 0x0200.</div>
<div><br>
</div>
<div>Please consider integrating this fix at your earliest convenience.</div>
<div><br>
</div>
<div>Thank you!</div>
<div><br>
</div>
<div>Best regards,</div>
<div>Peter<br>
</div>
</div>
<span id="cid:f_ll73xeuk0"><virtionet-21516.patch></span>_______________________________________________<br>
vbox-dev mailing list<br>
vbox-dev@virtualbox.org<br>
https://www.virtualbox.org/mailman/listinfo/vbox-dev<br>
</div>
</blockquote>
</div>
<br>
</div>
</body>
</html>