Opened 14 years ago
Closed 14 years ago
#8185 closed defect (fixed)
Possible memory leak in sf_follow_link (vboxsf.ko module) => Fixed in SVN
| Reported by: | Eugene | Owned by: | |
|---|---|---|---|
| Component: | shared folders | Version: | VirtualBox 4.0.2 |
| Keywords: | Cc: | ||
| Guest type: | Linux | Host type: | Windows |
Description
There is a possibility for a memory leak in sf_follow_link() function (src/VBox/Additions/linux/sharedfolders/lnkops.c).
The page allocated there via get_zeroed_page(GFP_KERNEL) will probably never be freed if vboxReadLink() fails. This happens, for example, when the shared folder contains a Windows symlink (a junction, to be exact) to a directory and one tries to list the contents of that directory from the guest or just cd to it via the link.
If I understand correctly what happens there, neither vboxReadLink() nor sf_follow_link() free that page, so it remains allocated and the pointer to it is lost when sf_follow_link() ends.
Host: Windows XP SP3 x86
Guest: OpenSUSE 11.3 x86
Guest Additions: 4.0.3 (r69551)
Attached are the VM log, VM configuration and the file with the call stacks of the memory leaks of this kind.
This problem as well as those reported in tickets #7705 and #7720 was detected by KEDR analysis system for Linux kernel modules.
Attachments (3)
Change History (6)
by , 14 years ago
comment:1 by , 14 years ago
| Summary: | Possible memory leak in sf_follow_link (vboxsf.ko module) → Possible memory leak in sf_follow_link (vboxsf.ko module) => Fixed in SVN |
|---|
That is absolutely correct. Thanks for this hint and thanks for the link! Fixed in r35854.
comment:3 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
VM log