VirtualBox

Ticket #3304 (closed defect: invalid)

Opened 5 years ago

Last modified 5 years ago

reserved identifier violation

Reported by: elfring Owned by:
Priority: minor Component: other
Version: VirtualBox 2.1.2 Keywords:
Cc: Guest type: other
Host type: other

Description

I suggest to try the search pattern "_+[A-Z]+" on the source files. You will find a couple of places where project-specific names begin with several underscores.

Examples:


This does not fit to the expected  naming conventions of the C language standard.

Change History

comment:1 Changed 5 years ago by sandervl73

  • Status changed from new to closed
  • Resolution set to invalid

Could you please not open defects for such trivial things? Report them on the developer's mailinglist instead.

comment:2 Changed 5 years ago by elfring

  • Status changed from closed to reopened
  • Resolution invalid deleted

I find it worth to mention also "trivial" issues about the source code here.

Some identifiers are reserved for the use in C/C++ compiler implementations.

I recommend to adjust include guards as a clean-up step.

comment:3 Changed 5 years ago by sandervl73

  • Status changed from reopened to closed
  • Resolution set to invalid

I asked you politely not to use the bug tracker system for such purposes. Report to the dev list and don't argue here.

comment:4 Changed 5 years ago by elfring

Would you like to add any  opinions or further  details?

comment:5 Changed 5 years ago by attoparsec

comment:6 Changed 5 years ago by elfring

  • Status changed from closed to reopened
  • Resolution invalid deleted

I have got the impression from the response by Knut St. Osmundsen that symbols like "BEGIN_DECLS" and "END_DECLS" need further considerations.

comment:7 Changed 5 years ago by sandervl73

  • Status changed from reopened to closed
  • Resolution set to invalid

It was discussed there, so no need to reopen.

comment:8 Changed 5 years ago by elfring

Will any further adjustments actions follow from this discussion?

comment:9 Changed 5 years ago by frank

The answer is: Yes, probably but most probably not within the next days /weeks. You might have noticed that we have more than 1400 bugs open. Some of them might be duplicates but there are still a lot of more important issues. And the last E-mail from Knut regarding this problem should be clear enough.

comment:10 Changed 5 years ago by elfring

Why do you want to keep this bug report closed when software developers and system testers will look at the involved details again in the future after issues with higher priority?

comment:11 Changed 5 years ago by elfring

I would appreciate if your last acknowledgement will also be indicated in the field "Resolution" of the tracking system.

Note: See TracTickets for help on using tickets.

www.oracle.com
ContactPrivacy policyTerms of Use