VirtualBox

Opened 3 years ago

Closed 19 months ago

#20523 closed defect (fixed)

Solaris vboxusbmon can panic when using alternate filesystems => fixed in svn/6.1.x x>26

Reported by: John Martin - Oracle Owned by:
Component: host support Version: VirtualBox 6.1.26
Keywords: Cc:
Guest type: other Host type: Solaris

Description (last modified by Ramshankar Venkataraman)

See SR 3-26796088091 for details. This SR has restricted content so only minimal information will be copied here. The Solaris vboxusbmon module can panic when using alternate attach points, in this case /a/devices/pseudo/vboxusbmon@0:vboxusbmon. The panic stack is:

ffffe3300b05a730 unix:die+147 ()
ffffe3300b05a800 unix:trap+1457 ()
ffffe3300b05a810 unix:_cmntrap+ea ()
ffffe3300b05a910 genunix:ddi_get_instance+c ()
ffffe3300b05a930 vboxusbmon:VBoxUSBMonSolarisGetInfo+3e ()
ffffe3300b05a970 genunix:dev_to_instance+52 ()
ffffe3300b05a9e0 genunix:devi_hold_by_dev+4a ()
ffffe3300b05aaa0 specfs:spec_open+bd ()
ffffe3300b05ab20 genunix:fop_open+18f ()
ffffe3300b05ad00 genunix:vn_openat+9b4 ()
ffffe3300b05ae90 genunix:copen+5c3 ()
ffffe3300b05aec0 genunix:uopen+23 ()
ffffe3300b05aef0 genunix:openat+2e ()
ffffe3300b05af00 unix:brand_sys_syscall+2ce ()

VBoxUSBMonSolarisGetInfo cannot assume the driver is attached. Since there is a single instance of this device, the suggested fix:

Index: src/VBox/HostDrivers/VBoxUSB/solaris/VBoxUSBMon-solaris.c
===================================================================
--- src/VBox/HostDrivers/VBoxUSB/solaris/VBoxUSBMon-solaris.c   (revision 90443)
+++ src/VBox/HostDrivers/VBoxUSB/solaris/VBoxUSBMon-solaris.c   (working copy)
@@ -402,10 +402,12 @@
     {
         case DDI_INFO_DEVT2DEVINFO:
             *ppvResult = (void *)g_pDip;
+            if (g_pDip == NULL)
+                rc = DDI_FAILURE;
             break;
 
         case DDI_INFO_DEVT2INSTANCE:
-            *ppvResult = (void *)(uintptr_t)ddi_get_instance(g_pDip);
+            *ppvResult = (void *)0;
             break;
 
         default:

Change History (3)

comment:1 by Ramshankar Venkataraman, 3 years ago

Description: modified (diff)

comment:2 by Ramshankar Venkataraman, 3 years ago

Thanks for the report.

The fix will be available in the next VirtualBox release/update.

comment:3 by paulson, 19 months ago

Resolution: fixed
Status: newclosed
Summary: Solaris vboxusbmon can panic when using alternate filesystemsSolaris vboxusbmon can panic when using alternate filesystems => fixed in svn/6.1.x x>26

This was addressed in VirtualBox 6.1.28.

Note: See TracTickets for help on using tickets.

© 2023 Oracle
ContactPrivacy policyTerms of Use