VirtualBox

Ticket #19148 (closed defect: fixed)

Opened 17 months ago

Last modified 17 months ago

SVN revision extracted from wrong variable in export_modules.sh

Reported by: jpalus Owned by: klaus
Component: other Version: VirtualBox 6.1.0
Keywords: Cc:
Guest type: other Host type: Linux

Description

It appears that VirtualBox 6.1 moved SVN revision information from VBOX_SVN_REV_FALLBACK variable to VBOX_SVN_REV_CONFIG_FALLBACK which was not reflected in export_modules.sh scripts (src/VBox/Additions/linux/export_modules.sh, src/VBox/HostDrivers/linux/export_modules.sh). Without SVN revision exported modules fail to compile. See attached patch.

Attachments

svn_rev.patch Download (3.1 KB) - added by jpalus 17 months ago.

Change History

Changed 17 months ago by jpalus

comment:1 Changed 17 months ago by fbatschu

Thanks, are you providing this patch under the MIT license? This needs to be explicitely stated in the bug/patch submittion.

For code contributions, please see:

https://www.virtualbox.org/wiki/Contributor_information

How to submit your contributions

If you have developed a patch for VirtualBox which you think could be useful for others and fits within the product's architecture, then you should submit it for inclusion. As a first step, you should execute the Contributor's Agreement as described above, which is a very straightforward and risk-free process. Then you should submit your patch to the vbox-dev mailing list or to the Developers Corner forum (see the "Community" page) along with a description of what it does. In case you have not signed the CA, please explicitly state that you are licensing the patch under the MIT license. 

comment:2 follow-up: ↓ 3 Changed 17 months ago by jpalus

I confirm that provided patch is under MIT license. Hopefully such statement is enough :).

comment:3 in reply to: ↑ 2 Changed 17 months ago by fbatschu

Replying to jpalus:

I confirm that provided patch is under MIT license. Hopefully such statement is enough :).

Absolutely. thanks!

comment:4 Changed 17 months ago by fbatschu

  • Owner set to fbatschu
  • Status changed from new to accepted

comment:5 Changed 17 months ago by klaus

Thanks for spotting this remaining issue.

The patch isn't right, though, because it would just revive the old, broken SVN revision fallback handling. Config.kmk isn't guaranteed to be updated on a release (in fact in 99.9% of all cases it isn't any more). The correct handling is implemented in Config.kmk (setting VBOX_SVN_REV_FALLBACK, taking the maximum of VBOX_SVN_REV_CONFIG_FALLBACK and VBOX_SVN_REV_VERSION_FALLBACK), but that's not usable from these scripts.

If you need a quick solution, you can get a perfect fallback for releases (but not for the public svn repository) by going for VBOX_SVN_REV_VERSION_FALLBACK in Version.kmk.

comment:6 follow-up: ↓ 7 Changed 17 months ago by klaus

Hope that r82582 fixes this issue (also spotted that the script still cared about vboxpci which is disabled for 6.1.0). Didn't have time to test.

comment:7 in reply to: ↑ 6 Changed 17 months ago by jpalus

Thanks! I confirm that it works fine.

comment:8 Changed 17 months ago by fbatschu

  • Owner changed from fbatschu to klaus
  • Status changed from accepted to assigned

comment:9 Changed 17 months ago by fbatschu

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.

www.oracle.com
ContactPrivacy policyTerms of Use