Opened 5 years ago
Last modified 4 years ago
#18869 closed defect
vbox_ttm.c - header file nit in include directive — at Version 3
| Reported by: | Frank Batschulat (Oracle) | Owned by: | Frank Batschulat (Oracle) |
|---|---|---|---|
| Component: | guest additions | Version: | VirtualBox 6.0.10 |
| Keywords: | drm header file | Cc: | |
| Guest type: | Linux | Host type: | Linux |
Description (last modified by )
From: "Gianfranco Costamagna" <> To: "VirtualBox Developer's List" <>
Subject: [vbox-dev] kernel 5.2 build fix [PATCH] Date: Mon, 26 Aug 2019 12:02:26 +0200
Hello, for some reasons, see [1] virtualbox doesn't build its kernel modules correctly on some configurations...The following patch fixes the issue
+--- virtualbox-6.0.10-dfsg.orig/src/VBox/Additions/linux/drm/vbox_ttm.c ++++ virtualbox-6.0.10-dfsg/src/VBox/Additions/linux/drm/vbox_ttm.c +@@ -33,7 +33,7 @@ + * Michael Thayer <> + */ + #include "vbox_drv.h" +-#include <ttm/ttm_page_alloc.h> ++#include <drm/ttm/ttm_page_alloc.h> + + #if LINUX_VERSION_CODE < KERNEL_VERSION(3, 18, 0) && !defined(RHEL_72) + #define PLACEMENT_FLAGS(placement) (placement)
please apply(you are not supposed to think that kernel is exporting -Iinclude/drm directory, and in all the other places it is not included that way)
see for comparison:src/VBox/Additions/linux/drm/vbox_drv.h:#include <drm/ttm/ttm_bo_api.h> src/VBox/Additions/linux/drm/vbox_drv.h:#include <drm/ttm/ttm_bo_driver.h> src/VBox/Additions/linux/drm/vbox_drv.h:#include <drm/ttm/ttm_placement.h> src/VBox/Additions/linux/drm/vbox_drv.h:#include <drm/ttm/ttm_memory.h> src/VBox/Additions/linux/drm/vbox_drv.h:#include <drm/ttm/ttm_module.h>
MIT licensed, as usual G. [1] https://bugs.debian.org/934483
https://www.virtualbox.org/pipermail/vbox-dev/2019-August/015323.html
Change History (3)
comment:1 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 5 years ago
| Owner: | set to |
|---|---|
| Status: | new → accepted |
comment:3 by , 5 years ago
| Description: | modified (diff) |
|---|
Note:
See TracTickets
for help on using tickets.
