VirtualBox

Ticket #18869 (closed defect: fixed)

Opened 3 weeks ago

Last modified 3 weeks ago

vbox_ttm.c - header file nit in include directive

Reported by: fbatschu Owned by: fbatschu
Component: guest additions Version: VirtualBox 6.0.10
Keywords: drm header file Cc:
Guest type: Linux Host type: Linux

Description (last modified by fbatschu) (diff)

From: "Gianfranco Costamagna" <> To: "VirtualBox Developer's List" <>

Subject: [vbox-dev] kernel 5.2 build fix [PATCH] Date: Mon, 26 Aug 2019 12:02:26 +0200

Hello, for some reasons, see [1] virtualbox doesn't build its kernel modules correctly on some configurations...The following patch fixes the issue

+--- virtualbox-6.0.10-dfsg.orig/src/VBox/Additions/linux/drm/vbox_ttm.c
++++ virtualbox-6.0.10-dfsg/src/VBox/Additions/linux/drm/vbox_ttm.c
+@@ -33,7 +33,7 @@
+  *          Michael Thayer <>
+  */
+ #include "vbox_drv.h"
+-#include <ttm/ttm_page_alloc.h>
++#include <drm/ttm/ttm_page_alloc.h>
+
+ #if LINUX_VERSION_CODE < KERNEL_VERSION(3, 18, 0) && !defined(RHEL_72)
+ #define PLACEMENT_FLAGS(placement) (placement)

please apply(you are not supposed to think that kernel is exporting -Iinclude/drm directory, and in all the other places it is not included that way)

see for comparison:src/VBox/Additions/linux/drm/vbox_drv.h:#include  
<drm/ttm/ttm_bo_api.h>
src/VBox/Additions/linux/drm/vbox_drv.h:#include <drm/ttm/ttm_bo_driver.h>
src/VBox/Additions/linux/drm/vbox_drv.h:#include <drm/ttm/ttm_placement.h>
src/VBox/Additions/linux/drm/vbox_drv.h:#include <drm/ttm/ttm_memory.h>
src/VBox/Additions/linux/drm/vbox_drv.h:#include <drm/ttm/ttm_module.h>

MIT licensed, as usual G. [1]  https://bugs.debian.org/934483

https://www.virtualbox.org/pipermail/vbox-dev/2019-August/015323.html

Change History

comment:1 Changed 3 weeks ago by fbatschu

  • Description modified (diff)

comment:2 Changed 3 weeks ago by fbatschu

  • Owner set to fbatschu
  • Status changed from new to accepted

comment:3 Changed 3 weeks ago by fbatschu

  • Description modified (diff)

comment:4 Changed 3 weeks ago by fbatschu

suggested fix:

VBox/Trunk fbatschu@hpbox trunk $ svn diff
Index: src/VBox/Additions/linux/drm/vbox_ttm.c
===================================================================
--- src/VBox/Additions/linux/drm/vbox_ttm.c	(revision 132923)
+++ src/VBox/Additions/linux/drm/vbox_ttm.c	(working copy)
@@ -33,7 +33,7 @@
  *          Michael Thayer <michael.thayer@oracle.com>
  */
 #include "vbox_drv.h"
-#include <ttm/ttm_page_alloc.h>
+#include <drm/ttm/ttm_page_alloc.h>
 
 #if LINUX_VERSION_CODE < KERNEL_VERSION(3, 18, 0) && !defined(RHEL_72)
 #define PLACEMENT_FLAGS(placement) (placement)
Last edited 3 weeks ago by fbatschu (previous) (diff)

comment:5 Changed 3 weeks ago by fbatschu

The problem has already been fixed in Trunk and 6.0 branch in a different way by changing the corresponding VBOX makefile:

src/VBox/Additions/linux/drm/Makefile.module.kms 

-- 51	 	        include/drm
-- 52	 	## @todo r=bird: -Iinclude/drm is ambigious.
++ 	51	        $(KERN_INCL)/drm

with Changeset 132724.

this will also be backported to the 5.2 branch.

closing bug as fixed.

comment:6 Changed 3 weeks ago by fbatschu

  • Status changed from accepted to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.

www.oracle.com
ContactPrivacy policyTerms of Use