VirtualBox

Ticket #18620 (closed defect: fixed)

Opened 2 weeks ago

Last modified 4 days ago

Module build fails on linux due to mistake in vboxnetadp/Makefile -> fixed in releases after 7 May 2019

Reported by: Ambroz Bizjak Owned by:
Component: host support Version: VirtualBox 6.0.6
Keywords: Cc:
Guest type: other Host type: Linux

Description

In some circumstances (probably out-of-tree build), the vboxnetadp module fails to build with an error like this:

cc1: fatal error: /build/virtualbox-6.0.6-modsrc/include/VBox/SUPDrvMangling.h: No such file or directory

This is fixed by changing

VBOXMOD_CFLAGS = -include $(KBUILD_EXTMOD)/include/VBox/SUPDrvMangling.h -fno-pie -Wno-declaration-after-statement

to

VBOXMOD_CFLAGS = -include $(VBOXNETADPT_DIR)include/VBox/SUPDrvMangling.h -fno-pie -Wno-declaration-after-statement

in the vboxnetadp Makefile. It appears that this change was missed during refactoring of the makefiles in this commit: https://www.virtualbox.org/changeset/77394/vbox. One can easily see the problem by comparing this line with the equivalent lines in Makefiles of other modules.

Attachments

fix_kbuild.patch Download (615 bytes) - added by Ambroz Bizjak 2 weeks ago.
Patch

Change History

Changed 2 weeks ago by Ambroz Bizjak

Patch

comment:1 Changed 12 days ago by michael

  • Summary changed from Module build fails on linux due to mistake in vboxnetadp/Makefile to Module build fails on linux due to mistake in vboxnetadp/Makefile -> fixed in releases after 7 May 2019

Thank you, fixed!

https://www.virtualbox.org/changeset/78436/vbox

I hope I got your name right in the change log (should there be accented characters?) Interestingly I was just looking at that place before I saw your patch as part of getting rid of $(KBUILD_EXTMOD) in Make files.

comment:2 Changed 12 days ago by michael

By the way, it would be nice if you could add a "submitted under the MIT licence" comment to this patch. Thanks.

comment:3 Changed 5 days ago by michael

  • Status changed from new to closed
  • Resolution set to fixed

comment:4 Changed 4 days ago by Ambroz Bizjak

Thanks. Patch is submitted under the MIT licence. The name is fine.

Note: See TracTickets for help on using tickets.

www.oracle.com
ContactPrivacy policyTerms of Use