#18620 closed defect (fixed)
Module build fails on linux due to mistake in vboxnetadp/Makefile -> fixed in releases after 7 May 2019
| Reported by: | Ambroz Bizjak | Owned by: | |
|---|---|---|---|
| Component: | host support | Version: | VirtualBox 6.0.6 |
| Keywords: | Cc: | ||
| Guest type: | other | Host type: | Linux |
Description
In some circumstances (probably out-of-tree build), the vboxnetadp module fails to build with an error like this:
cc1: fatal error: /build/virtualbox-6.0.6-modsrc/include/VBox/SUPDrvMangling.h: No such file or directory
This is fixed by changing
VBOXMOD_CFLAGS = -include $(KBUILD_EXTMOD)/include/VBox/SUPDrvMangling.h -fno-pie -Wno-declaration-after-statement
to
VBOXMOD_CFLAGS = -include $(VBOXNETADPT_DIR)include/VBox/SUPDrvMangling.h -fno-pie -Wno-declaration-after-statement
in the vboxnetadp Makefile. It appears that this change was missed during refactoring of the makefiles in this commit: https://www.virtualbox.org/changeset/77394/vbox. One can easily see the problem by comparing this line with the equivalent lines in Makefiles of other modules.
Attachments (1)
Change History (5)
by , 5 years ago
| Attachment: | fix_kbuild.patch added |
|---|
comment:1 by , 5 years ago
| Summary: | Module build fails on linux due to mistake in vboxnetadp/Makefile → Module build fails on linux due to mistake in vboxnetadp/Makefile -> fixed in releases after 7 May 2019 |
|---|
Thank you, fixed!
https://www.virtualbox.org/changeset/78436/vbox
I hope I got your name right in the change log (should there be accented characters?) Interestingly I was just looking at that place before I saw your patch as part of getting rid of $(KBUILD_EXTMOD) in Make files.
comment:2 by , 5 years ago
By the way, it would be nice if you could add a "submitted under the MIT licence" comment to this patch. Thanks.
comment:3 by , 5 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Patch