VirtualBox

Opened 6 years ago

#17768 new defect

hdaR3WalClkSet compile bug in non VBOX_STRICT

Reported by: gim Owned by:
Component: audio Version: VirtualBox 5.2.12
Keywords: Cc:
Guest type: all Host type: all

Description

VirtualBox/src/VBox/Devices/Audio/DevHDACommon.cpp: In function ‘bool hdaR3WalClkSet(PHDASTATE, uint64_t, bool)’:
VirtualBox/src/VBox/Devices/Audio/DevHDACommon.cpp:183:15: error: ‘u64WalClkCur’ was not declared in this scope
               u64WalClkCur, u64WalClk, fForce,

u64WalClkCur will be defined only when VBOX_STRICT defined

bool hdaR3WalClkSet(PHDASTATE pThis, uint64_t u64WalClk, bool fForce)
{
...

# ifdef VBOX_STRICT
    const uint64_t u64WalClkCur       = ASMAtomicReadU64(&pThis->u64WalClk);
# endif

...
    const uint64_t u64WalClkNew = hdaWalClkGetCurrent(pThis);

    Log3Func(("Cur: %RU64, New: %RU64 (force %RTbool) -> %RU64 %s\n",
              u64WalClkCur, u64WalClk, fForce,
              u64WalClkNew, u64WalClkNew == u64WalClk ? "[OK]" : "[DELAYED]"));

    return (u64WalClkNew == u64WalClk);
}

Attachments (1)

DevHDA.patch (736 bytes ) - added by gim 6 years ago.

Download all attachments as: .zip

Change History (1)

by gim, 6 years ago

Attachment: DevHDA.patch added
Note: See TracTickets for help on using tickets.

© 2023 Oracle
ContactPrivacy policyTerms of Use