VirtualBox

Opened 8 years ago

Closed 8 years ago

#15896 closed defect (fixed)

linux kernel-4.8-rc4 fail to build guest additions vboxvideo/vbox_ttm.c error: too few arguments to function ‘ttm_bo_move_memcpy’ -> fixed in releases higher than 5.1.4

Reported by: sergiomb Owned by:
Component: guest additions/x11/graphics Version: VirtualBox 5.1.4
Keywords: Cc:
Guest type: Linux Host type: Linux

Description

/tmp/akmodsbuild.rAatyUU4/BUILD/VirtualBox-kmod-5.1.4/_kmod_build_4.8.0-0.rc4.git3.2.fc26.x86_64/vboxvideo/vbox_ttm.c: In function ‘vbox_bo_move’:
/tmp/akmodsbuild.rAatyUU4/BUILD/VirtualBox-kmod-5.1.4/_kmod_build_4.8.0-0.rc4.git3.2.fc26.x86_64/vboxvideo/vbox_ttm.c:224:9: error: too few arguments to function ‘ttm_bo_move_memcpy’
     r = ttm_bo_move_memcpy(bo, evict, no_wait_gpu, new_mem);
         ^
In file included from /tmp/akmodsbuild.rAatyUU4/BUILD/VirtualBox-kmod-5.1.4/_kmod_build_4.8.0-0.rc4.git3.2.fc26.x86_64/vboxvideo/vbox_drv.h:62:0,
                 from /tmp/akmodsbuild.rAatyUU4/BUILD/VirtualBox-kmod-5.1.4/_kmod_build_4.8.0-0.rc4.git3.2.fc26.x86_64/vboxvideo/vbox_ttm.c:48:
./include/drm/ttm/ttm_bo_driver.h:1002:12: note: declared here
 extern int ttm_bo_move_memcpy(struct ttm_buffer_object *bo,
            ^
scripts/Makefile.build:289: recipe for target '/tmp/akmodsbuild.rAatyUU4/BUILD/VirtualBox-kmod-5.1.4/_kmod_build_4.8.0-0.rc4.git3.2.fc26.x86_64/vboxvideo/vbox_ttm.o' failed

I began to dig and it is https://patchwork.kernel.org/patch/9157413/ it easy to fix just for kernel-4.8-rc4

-    r = ttm_bo_move_memcpy(bo, evict, no_wait_gpu, new_mem);
+    r = ttm_bo_move_memcpy(bo, evict, interruptible, no_wait_gpu, new_mem);

for all kernels leave up to you.

Thanks

Attachments (1)

5.1.4-2-for-4.8.0-0.rc5.git2.2.fc26.x86_64.failed.log (59.3 KB ) - added by sergiomb 8 years ago.
for-4.8.0-0.rc5.git2.2.fc26.x86_64.failed.log

Download all attachments as: .zip

Change History (8)

comment:2 by Michael Thayer, 8 years ago

Please try the latest Additions test build<1>.

<1> https://www.virtualbox.org/wiki/Testbuilds

by sergiomb, 8 years ago

for-4.8.0-0.rc5.git2.2.fc26.x86_64.failed.log

comment:3 by sergiomb, 8 years ago

Hi, it is failing with just released 4.8.0-0.rc5.git2.2.fc26.x86_64 , since don't find any patch yet in https://build.opensuse.org/package/show/Virtualization/virtualbox , let me know if it an easy fix and what is the patch . Thanks.

comment:4 by Michael Thayer, 8 years ago

Index: src/VBox/Additions/linux/drm/vbox_drv.c
===================================================================
--- src/VBox/Additions/linux/drm/vbox_drv.c	(revision 110587)
+++ src/VBox/Additions/linux/drm/vbox_drv.c	(working copy)
@@ -65,7 +65,7 @@
 
 static struct drm_driver driver;
 
-static DEFINE_PCI_DEVICE_TABLE(pciidlist) =
+static const struct pci_device_id pciidlist[] =
 {
     {0x80ee, 0xbeef, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
     {0, 0, 0},

comment:5 by sergiomb, 8 years ago

Thanks , now I can build kmods for 4.8.0-0.rc5.git2.2

comment:6 by Michael Thayer, 8 years ago

Summary: linux kernel-4.8-rc4 fail to build guest additions vboxvideo/vbox_ttm.c error: too few arguments to function ‘ttm_bo_move_memcpy’linux kernel-4.8-rc4 fail to build guest additions vboxvideo/vbox_ttm.c error: too few arguments to function ‘ttm_bo_move_memcpy’ -> fixed in releases higher than 5.1.4

Thanks for confirming.

comment:7 by Frank Mehnert, 8 years ago

Resolution: fixed
Status: newclosed

Fix is part of VBox 5.1.6.

Note: See TracTickets for help on using tickets.

© 2023 Oracle
ContactPrivacy policyTerms of Use