VirtualBox

Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#1263 closed defect (fixed)

[PATCH] Linux kernel >= 2.6.25 no longer has change_page_attr => Fixed in 1.6

Reported by: Michel Salim Owned by:
Component: other Version: VirtualBox 1.5.6
Keywords: linux api-breakage Cc:
Guest type: other Host type: other

Description

change_page_attr has been removed from the upcoming Linux kernel 2.6.25. The kernel version test currently conditionally compiles some change_page_attr workarounds for kernels >= 2.4.20; this now needs to be upper-bounded as well.

Patch attached, lightly tested (I tried booting DragonFly BSD, and got to the boot menu, but then hit a known bug that DF BSD would freeze at the countdown screen)

Attachments (1)

vbox-r7168-chpgattr-out.patch (1.4 KB ) - added by Michel Salim 16 years ago.
Patch against vbox trunk (r7168)

Download all attachments as: .zip

Change History (6)

by Michel Salim, 16 years ago

Patch against vbox trunk (r7168)

comment:1 by Frank Mehnert, 16 years ago

Hmm, you checked this on a x86 platform, right? Because on AMD64 changing of the page attributes should be necessary.

comment:2 by Michel Salim, 16 years ago

No, this is on AMD64. The chage_page_attr function is simply not part of the 2.6.25 API at all -- there is a discussion in the LKML about this:

http://lkml.org/lkml/2008/2/17/319

comment:3 by Frank Mehnert, 16 years ago

Right, on lkml.org they write that some has to use set_memory_nx()/set_memory_x(). You cannot simply ignore these calls. The fix should be in SVN now.

comment:4 by Frank Mehnert, 16 years ago

Summary: [PATCH] Linux kernel >= 2.6.25 no longer has change_page_attr[PATCH] Linux kernel >= 2.6.25 no longer has change_page_attr => Fixed in 1.6

comment:5 by Frank Mehnert, 16 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.

© 2023 Oracle
ContactPrivacy policyTerms of Use