[vbox-dev] FreeBSD virtualbox port and VBoxNetDHCP crash fix patch

[Valdis Kl=?utf-8?Q?=c4=93?=tnieks]

On Sun, 14 Mar 2021 10:55:11 +0100, Guido Falsi said:

> BTW is there some review tool you are using? Sending patches as 
> attachments via mailing list does not look very efficient for review.

And yet, the Linux kernel managed 15,477 commits between 5.10 and 5.11, for an
average around 170 per day, the vast majority of which weren't attachments but
up in the main body of the email.

Most maintainers prefer the patch *not* as attachments, as most MUAs show the
main/first bodypart inline, but there's no guarantee that a patch in an
attachment is easily readable directly. Having it inline results in an
efficient workflow - the maintainer just has to keep scrolling to read through
the patch (which they'd have to do whether it was inline or saved and read
inside an editor or /bin/more), and if the patch looks good, feed it to 'git
am' (which assumes it's fed an entire email, not an attachment).  If it's *not*
good, just hit 'reply all' and Poof! you're set up for doing line-by-line
reply.

Trying to do the same workflow if the patch is in an attachment is much more
difficult with most MUAs.