[vbox-dev] FreeBSD virtualbox port and VBoxNetDHCP crash fix patch

[Guido Falsi]

On 14/03/21 03:37, Valdis Klētnieks wrote:
> On Sat, 13 Mar 2021 16:21:23 +0100, Guido Falsi said:
> 
>> As stated above more patches need to be merged but before proposing them
>> I need to clean them up a little and also group some of them by subject
>> and not by patched file like the ports tree does. Next thing I plan to
>> propose is a patch with all the "#if __FreeBSD_version" changes bundled
>> together.
> 
> It's probably better off submitting a stream of patches rather than one big
> patch, because version control systems like git will then allow dealing with
> issues in one part of the patch a lot easier.  The patches that work can be
> committed while work proceeds in fixing the ones with issues, rather than the
> entire humongous patch being blocked because there's a 2-line change that
> causes problems.
> 

I agree but these are all related and already being used in FreeBSD.

Usually the preference is to have related patch in a bunch. Anyway if 
you prefer another method I'll split them in smaller blocks.

BTW is there some review tool you are using? Sending patches as 
attachments via mailing list does not look very efficient for review.

-- 
Guido Falsi <mad at madpilot.net>