[vbox-dev] Virtualbox 6.1.14a fails to build when the liblzf library is provided by system.

[Jose R R]

On Thu, Sep 10, 2020 at 1:59 AM Sérgio Basto <sergio at serjux.com> wrote:
>
> I tried on Fedora but still doesn't compile [1]
> any clue ?
>
> [1]
> https://copr.fedorainfracloud.org/coprs/sergiomb/vboxfor23/build/1655914/
> /builddir/build/BUILD/VirtualBox-6.1.14/obj/lib/RuntimeR3.a(zip.o): In
> function `rtZipLZFCompressBuffer(RTZIPCOMP*, unsigned char const*,
> unsigned long)':
> /builddir/build/BUILD/VirtualBox-
> 6.1.14/src/VBox/Runtime/common/zip/zip.cpp:956: undefined reference to
> `lzf_compress(void const*, unsigned int, void*, unsigned int)'
> /builddir/build/BUILD/VirtualBox-
> 6.1.14/src/VBox/Runtime/common/zip/zip.cpp:968: undefined reference to
> `lzf_compress(void const*, unsigned int, void*, unsigned int)'
> /builddir/build/BUILD/VirtualBox-6.1.14/obj/lib/RuntimeR3.a(zip.o): In
> function `rtZipLZFDecompress(RTZIPDECOMP*, void*, unsigned long,
> unsigned long*)':
> /builddir/build/BUILD/VirtualBox-
> 6.1.14/src/VBox/Runtime/common/zip/zip.cpp:1170: undefined reference to
> `lzf_decompress(void const*, unsigned int, void*, unsigned int)'
> /builddir/build/BUILD/VirtualBox-
> 6.1.14/src/VBox/Runtime/common/zip/zip.cpp:1183: undefined reference to
> `lzf_decompress(void const*, unsigned int, void*, unsigned int)'
> /builddir/build/BUILD/VirtualBox-6.1.14/obj/lib/RuntimeR3.a(zip.o): In
> function `RTZipBlockCompress':
> /builddir/build/BUILD/VirtualBox-
> 6.1.14/src/VBox/Runtime/common/zip/zip.cpp:1763: undefined reference to
> `lzf_compress(void const*, unsigned int, void*, unsigned int)'
> /builddir/build/BUILD/VirtualBox-6.1.14/obj/lib/RuntimeR3.a(zip.o): In
> function `RTZipBlockDecompress':
> /builddir/build/BUILD/VirtualBox-
> 6.1.14/src/VBox/Runtime/common/zip/zip.cpp:1855: undefined reference to
> `lzf_decompress(void const*, unsigned int, void*, unsigned int)'
> collect2: error: ld returned 1 exit status
> kmk: *** [/builddir/build/BUILD/VirtualBox-6.1.14/obj/obj/vbox-
> img/vbox-img] Error 1
>
> On Thu, 2020-09-10 at 01:52 +0200, Thibault Vataire wrote:
> > Yes this patch fixes the problem.
> > Regards,
> > Thibault Vataire
> >
> >
> > Le 09/09/2020 à 01:34, Sérgio Basto a écrit :
> > > On Tue, 2020-09-08 at 23:02 +0200, Thibault Vataire wrote:
> > > > Hello,
> > > >
> > > > Virtualbox 6.1.14 fails to build when the liblzf library is
> > > > provided
> > > > by
> > > > system, but succeeds if the liblzf library is build from
> > > > virtualbox
> > > > sources.
> > > >
> > > > System info :
> > > >       Description:    Debian GNU/Linux 10 (buster)
> > > >       liblzf-dev/buster-backports,now 3.6-2~bpo10+1
> > > > amd64  [installé]
> > > >       liblzf1/buster-backports,now 3.6-2~bpo10+1
> > > > amd64  [installé,
> > > > automatique]
> > > >
> > > >
> > > > Steps to reproduce :
> > > > 1/ install liblzf & liblzf-dev packages from debian repository
> > > > 2/ decompress sources from
> > > > https://download.virtualbox.org/virtualbox/6.1.14/VirtualBox-6.1.14a.tar.bz2
> > > > 4/ configure and start build.
> > > >
> > > > Result :
> > > > ...
> > > > kBuild: Compiling tstVDIo -
> > > > /tmp/VirtualBox-
> > > > 6.1.14/src/VBox/Storage/testcase/VDScriptInterp.cpp
> > > > kmk: *** No rule to make target
> > > > '/tmp/VirtualBox-6.1.14/out/linux.amd64/release/lib/VBox-
> > > > liblzf.a',
> > > > needed by
> > > > '/tmp/VirtualBox-6.1.14/out/linux.amd64/release/obj/vbox-
> > > > img/vbox-
> > > > img'.
> > > > Stop.
> > > > kmk: *** Waiting for unfinished jobs....
> > > > ...
> > > >
> > > > Expected result :
> > > > If ./configure returns : "Checking for liblzf: found LZF API
> > > > version
> > > > 1.5, OK."
> > > > the build should complete successfully.
> > > is this [1] the fix ?
> > >
> > > [1]
> > > https://salsa.debian.org/pkg-virtualbox-team/virtualbox/-/blob/master/debian/patches/changeset_86042.patch
> > >
> > > > Regards,
> > > > Thibault Vataire
> --
> Sérgio M. B.[]
Assuming you downloaded and expanded source:
https://download.virtualbox.org/virtualbox/6.1.14/VirtualBox-6.1.14a.tar.bz2

The patch you referenced, i.e.,
https://salsa.debian.org/pkg-virtualbox-team/virtualbox/-/blob/master/debian/patches/changeset_86042.patch

*may not* apply at proper line number(s), please try:

--- Cut here ----------------------
 Config.kmk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Config.kmk b/Config.kmk
index 4b976479..1ddac5c7 100644
--- a/Config.kmk
+++ b/Config.kmk
@@ -5457,7 +5457,7 @@ if1of ($(KBUILD_TARGET),os2 win)
      $(SDK_VBOX_ZLIB_STATIC_LIBS)
 else
  TEMPLATE_VBoxR3Static_LIBS        += \
-     $(PATH_STAGE_LIB)/VBox-liblzf$(VBOX_SUFF_LIB) \
+    $(SDK_VBOX_LZF_LIBS) \
      $(SDK_VBOX_ZLIB_LIBS)
  if1of ($(KBUILD_TARGET),darwin freebsd)
   TEMPLATE_VBoxR3Static_LIBS       += iconv
--
2.27.0
----------- Cut here ------------------------

The above will suffice if attached one does not make it through the filters.

Subsequently, VirtualBox-6.1.14a will build nicely.

Good luck!

-- 
Jose R R
http://metztli.it
---------------------------------------------------------------------------------------------
Download Metztli Reiser4: Debian Buster w/ Linux 5.7.19 AMD64
---------------------------------------------------------------------------------------------
feats ZSTD compression https://sf.net/projects/metztli-reiser4/
-------------------------------------------------------------------------------------------
Official current Reiser4 resources: https://reiser4.wiki.kernel.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: VirtualBox-6.1.14a_Config.kmk.patch
Type: text/x-patch
Size: 766 bytes
Desc: not available
URL: <http://www.virtualbox.org/pipermail/vbox-dev/attachments/20200910/9b5e0c68/attachment.bin>