[vbox-dev] Virtualbox 6.1.14a fails to build when the liblzf library is provided by system.

[Sérgio Basto]

I tried on Fedora but still doesn't compile [1] 
any clue ? 

[1]
https://copr.fedorainfracloud.org/coprs/sergiomb/vboxfor23/build/1655914/
/builddir/build/BUILD/VirtualBox-6.1.14/obj/lib/RuntimeR3.a(zip.o): In
function `rtZipLZFCompressBuffer(RTZIPCOMP*, unsigned char const*,
unsigned long)':
/builddir/build/BUILD/VirtualBox-
6.1.14/src/VBox/Runtime/common/zip/zip.cpp:956: undefined reference to
`lzf_compress(void const*, unsigned int, void*, unsigned int)'
/builddir/build/BUILD/VirtualBox-
6.1.14/src/VBox/Runtime/common/zip/zip.cpp:968: undefined reference to
`lzf_compress(void const*, unsigned int, void*, unsigned int)'
/builddir/build/BUILD/VirtualBox-6.1.14/obj/lib/RuntimeR3.a(zip.o): In
function `rtZipLZFDecompress(RTZIPDECOMP*, void*, unsigned long,
unsigned long*)':
/builddir/build/BUILD/VirtualBox-
6.1.14/src/VBox/Runtime/common/zip/zip.cpp:1170: undefined reference to
`lzf_decompress(void const*, unsigned int, void*, unsigned int)'
/builddir/build/BUILD/VirtualBox-
6.1.14/src/VBox/Runtime/common/zip/zip.cpp:1183: undefined reference to
`lzf_decompress(void const*, unsigned int, void*, unsigned int)'
/builddir/build/BUILD/VirtualBox-6.1.14/obj/lib/RuntimeR3.a(zip.o): In
function `RTZipBlockCompress':
/builddir/build/BUILD/VirtualBox-
6.1.14/src/VBox/Runtime/common/zip/zip.cpp:1763: undefined reference to
`lzf_compress(void const*, unsigned int, void*, unsigned int)'
/builddir/build/BUILD/VirtualBox-6.1.14/obj/lib/RuntimeR3.a(zip.o): In
function `RTZipBlockDecompress':
/builddir/build/BUILD/VirtualBox-
6.1.14/src/VBox/Runtime/common/zip/zip.cpp:1855: undefined reference to
`lzf_decompress(void const*, unsigned int, void*, unsigned int)'
collect2: error: ld returned 1 exit status
kmk: *** [/builddir/build/BUILD/VirtualBox-6.1.14/obj/obj/vbox-
img/vbox-img] Error 1

On Thu, 2020-09-10 at 01:52 +0200, Thibault Vataire wrote:
> Yes this patch fixes the problem.
> Regards,
> Thibault Vataire
> 
> 
> Le 09/09/2020 à 01:34, Sérgio Basto a écrit :
> > On Tue, 2020-09-08 at 23:02 +0200, Thibault Vataire wrote:
> > > Hello,
> > > 
> > > Virtualbox 6.1.14 fails to build when the liblzf library is
> > > provided
> > > by
> > > system, but succeeds if the liblzf library is build from
> > > virtualbox
> > > sources.
> > > 
> > > System info :
> > >       Description:    Debian GNU/Linux 10 (buster)
> > >       liblzf-dev/buster-backports,now 3.6-2~bpo10+1
> > > amd64  [installé]
> > >       liblzf1/buster-backports,now 3.6-2~bpo10+1
> > > amd64  [installé,
> > > automatique]
> > > 
> > > 
> > > Steps to reproduce :
> > > 1/ install liblzf & liblzf-dev packages from debian repository
> > > 2/ decompress sources from
> > > https://download.virtualbox.org/virtualbox/6.1.14/VirtualBox-6.1.14a.tar.bz2
> > > 4/ configure and start build.
> > > 
> > > Result :
> > > ...
> > > kBuild: Compiling tstVDIo -
> > > /tmp/VirtualBox-
> > > 6.1.14/src/VBox/Storage/testcase/VDScriptInterp.cpp
> > > kmk: *** No rule to make target
> > > '/tmp/VirtualBox-6.1.14/out/linux.amd64/release/lib/VBox-
> > > liblzf.a',
> > > needed by
> > > '/tmp/VirtualBox-6.1.14/out/linux.amd64/release/obj/vbox-
> > > img/vbox-
> > > img'.
> > > Stop.
> > > kmk: *** Waiting for unfinished jobs....
> > > ...
> > > 
> > > Expected result :
> > > If ./configure returns : "Checking for liblzf: found LZF API
> > > version
> > > 1.5, OK."
> > > the build should complete successfully.
> > is this [1] the fix ?
> > 
> > [1]
> > https://salsa.debian.org/pkg-virtualbox-team/virtualbox/-/blob/master/debian/patches/changeset_86042.patch
> > 
> > > Regards,
> > > Thibault Vataire
-- 
Sérgio M. B.