[vbox-dev] [Patch] Improved showvminfo USB information

[Kalogrianitis Socratis]

Just a small patch, which seems to make sense (at least to me). I got the idea from an understandable misunderstanding: https://forums.virtualbox.org/viewtopic.php?f=8&t=86126&p=410366#p410367

-------------------------------------
VBoxManage showvminfo "Debian9"
...
USB:             disabled
EHCI:            disabled
XHCI:            enabled
...


User: I don't know why command "VBoxManage showvminfo "Debian9" " showed that USB is disabled...
-------------------------------------

I can see that having USB labeled as "disabled" could confuse some users. The patch modifies the output so that it's more in line with the VM settings, i.e. both numeric USB, and the *HCI ones.

Socratis


Index: src/VBox/Frontends/VBoxManage/VBoxManageInfo.cpp
===================================================================
--- src/VBox/Frontends/VBoxManage/VBoxManageInfo.cpp	(revision 70243)
+++ src/VBox/Frontends/VBoxManage/VBoxManageInfo.cpp	(working copy)
@@ -1988,19 +1988,19 @@
         }
 
         if (details == VMINFO_MACHINEREADABLE)
-            RTPrintf("usb=\"%s\"\n", fOhciEnabled ? "on" : "off");
+            RTPrintf("ohci=\"%s\"\n", fOhciEnabled ? "on" : "off");
         else
-            RTPrintf("USB:             %s\n", fOhciEnabled ? "enabled" : "disabled");
+            RTPrintf("USB 1.1 (OHCI):  %s\n", fOhciEnabled ? "enabled" : "disabled");
 
         if (details == VMINFO_MACHINEREADABLE)
             RTPrintf("ehci=\"%s\"\n", fEhciEnabled ? "on" : "off");
         else
-            RTPrintf("EHCI:            %s\n", fEhciEnabled ? "enabled" : "disabled");
+            RTPrintf("USB 2.0 (EHCI):  %s\n", fEhciEnabled ? "enabled" : "disabled");
 
         if (details == VMINFO_MACHINEREADABLE)
             RTPrintf("xhci=\"%s\"\n", fXhciEnabled ? "on" : "off");
         else
-            RTPrintf("XHCI:            %s\n", fXhciEnabled ? "enabled" : "disabled");
+            RTPrintf("USB 3.0 (xHCI):  %s\n", fXhciEnabled ? "enabled" : "disabled");
     }
 
     ComPtr<IUSBDeviceFilters> USBFlts;