[vbox-dev] Faulty logging code

Frank Mehnert frank.mehnert at oracle.com
Thu Jul 24 08:19:57 GMT 2014


Hi Ray,

On Wednesday 23 July 2014 22:29:11 Ray Yang wrote:
> The following logging code is missing the last parameter for uTagSrc:
> 
> 
> static int  apic_deliver(APICDeviceInfo *pDev, APICState *pApic,
>                          uint8_t dest, uint8_t dest_mode,
>                          uint8_t delivery_mode, uint8_t vector_num,
>                          uint8_t polarity, uint8_t trigger_mode)
> {
>     int dest_shorthand = (pApic->icr[0] >> 18) & 3;
>     LogFlow(("apic_deliver dest=%x dest_mode=%x dest_shorthand=%x
> delivery_mode=%x vector_num=%x polarity=%x trigger_mode=%x
> uTagSrc=%#x\n", dest, dest_mode, dest_shorthand, delivery_mode,
> vector_num, polarity, trigger_mode));
> 
> So it results the following log message:
> 
> apic_deliver dest=1 dest_mode=0 dest_shorthand=0 delivery_mode=5
> vector_num=0 polarity=1 trigger_mode=1 uTagSrc=0xcccccccc

thanks for the report, fixed in current trunk.

Frank
-- 
Dr.-Ing. Frank Mehnert | Software Development Director, VirtualBox
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | 71384 Weinstadt, Germany

Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Geschäftsführer: Jürgen Kunz

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher




More information about the vbox-dev mailing list