[vbox-dev] crash when Log is enable

[Frank Mehnert]

On Monday 14 February 2011 02:59:55 Howard Su wrote:
> please see the following patch. I don't think I fixed all the problem.
> but this is one that I saw several times.
> 
> Index:
> libs/xpcom18a4/ipc/ipcd/extensions/dconnect/src/ipcDConnectService.cpp
> =================================================================== ---
> libs/xpcom18a4/ipc/ipcd/extensions/dconnect/src/ipcDConnectService.cpp
> (revision 35941)
> +++ libs/xpcom18a4/ipc/ipcd/extensions/dconnect/src/ipcDConnectService.cpp
>      (working copy)
> @@ -2221,7 +2221,7 @@
>  DConnectStub::~DConnectStub()
>  {
>  #ifdef IPC_LOGGING
> -  const char *name;
> +  const char *name = NULL;
>    mIInfo->GetNameShared(&name);
>    LOG(("{%p} DConnectStub::<dtor>(): peer=%d instance=0x%Lx {%s}\n",
>         this, mPeerID, mInstance, name));
> 
> GetNameShared will not clear name to NULL if there is not name which
> cause crash.

Applied, thanks.

Kind regards,

Frank
-- 
ORACLE Deutschland B.V. & Co. KG   Dr.-Ing. Frank Mehnert
Werkstrasse 24                     Staff Engineer, VirtualBox
71384 Weinstadt, Germany           mailto:frank.mehnert at oracle.com

Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Rijnzathe 6, 3454PV De Meern, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://www.virtualbox.org/pipermail/vbox-dev/attachments/20110216/aed67b58/attachment.sig>