[vbox-dev] crash when Log is enable

Howard Su howard0su at gmail.com
Mon Feb 14 01:59:55 GMT 2011


please see the following patch. I don't think I fixed all the problem.
but this is one that I saw several times.

Index: libs/xpcom18a4/ipc/ipcd/extensions/dconnect/src/ipcDConnectService.cpp
===================================================================
--- libs/xpcom18a4/ipc/ipcd/extensions/dconnect/src/ipcDConnectService.cpp
     (revision 35941)
+++ libs/xpcom18a4/ipc/ipcd/extensions/dconnect/src/ipcDConnectService.cpp
     (working copy)
@@ -2221,7 +2221,7 @@
 DConnectStub::~DConnectStub()
 {
 #ifdef IPC_LOGGING
-  const char *name;
+  const char *name = NULL;
   mIInfo->GetNameShared(&name);
   LOG(("{%p} DConnectStub::<dtor>(): peer=%d instance=0x%Lx {%s}\n",
        this, mPeerID, mInstance, name));

GetNameShared will not clear name to NULL if there is not name which
cause crash.

-- 
-Howard




More information about the vbox-dev mailing list