[vbox-dev] crash when restoring a snapshot

[Huihong Luo]

seems that in this function: mMediaData.backedUpData() might be NULL
 
void SessionMachine::restoreSnapshotHandler(RestoreSnapshotTask &aTask)
{
 
// Normally we "detach" the medium by removing the attachment object
// from the current machine data; saveSettings() below would then
// compare the current machine data with the one in the backup
// and actually call Medium::detachFrom(). But that works only half
// the time in our case so instead we force a detachment here:
// remove from machine data
mMediaData->mAttachments.remove(pAttach);
// remove it from the backup or else saveSettings will try to detach
// it again and assert
mMediaData.backedUpData()->mAttachments.remove(pAttach);
// then clean up backrefs
pMedium->detachFrom(mData->mUuid);
 
}
 
  VBoxSVC.exe!std::list<ComObjPtr<MediumAttachment>,std::allocator<ComObjPtr<MediumAttachment> > >::end()  Line 538 + 0x7 bytes C++
  VBoxSVC.exe!std::list<ComObjPtr<MediumAttachment>,std::allocator<ComObjPtr<MediumAttachment> > >::remove(const ComObjPtr<MediumAttachment> & _Val_arg={...})  Line 907 C++
> VBoxSVC.exe!SessionMachine::restoreSnapshotHandler(SessionMachine::RestoreSnapshotTask & aTask={...})  Line 1916 C++
  VBoxSVC.exe!SessionMachine::RestoreSnapshotTask::handler()  Line 1178 C++
  VBoxSVC.exe!SessionMachine::taskHandler(RTTHREADINT * __formal=0x0357d9d8, void * pvUser=0x039c76a0)  Line 1215 + 0xe bytes C++
  VBoxRT.dll!rtThreadMain(RTTHREADINT * pThread=0x0357d9d8, unsigned int NativeThread=7124, const char * pszThreadName=0x0357df54)  Line 679 + 0xa bytes C++
  VBoxRT.dll!rtThreadNativeMain(void * pvArgs=0x0357d9d8)  Line 102 + 0xe bytes C++
  msvcr80.dll!_callthreadstartex()  Line 348 + 0x6 bytes C
  msvcr80.dll!_threadstartex(void * ptd=0x034a0b28)  Line 326 + 0x5 bytes C
  kernel32.dll!@BaseThreadInitThunk at 12()  + 0x12 bytes 
  ntdll.dll!___RtlUserThreadStart at 8()  + 0x27 bytes 
  ntdll.dll!__RtlUserThreadStart at 8()  + 0x1b bytes 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.virtualbox.org/pipermail/vbox-dev/attachments/20100729/bdb2a84e/attachment.html>