[vbox-dev] [PATCH] rdesktop-vrdp SEGVs with XCreateImage/XPutImage call in ui_desktop_restore()

[Frank Mehnert]

Hi,

On Monday 09 March 2009, Taisuke Yamada wrote:
> I've been experiencing frequent crash of rdesktop-vrdp on Debian
> lenny, and I found it is due to obsolete XCreateImage call still
> left in xwin.c.
>
> Sometime in 2007, X.org has added extra sanity check for arguments to
> XCreateImage, and now returns NULL for (now-invalid) XCreateImage call
> in ui_desktop_restore(). This is causing SEGV in following XPutImage.
>
> I have attached one-line patch to fix the problem, but I also found
> rdesktop has exactly the same patch in 2007 (bee URL below):
>
> -
> http://rdesktop.cvs.sourceforge.net/viewvc/rdesktop/rdesktop/xwin.c?r1=1.22
>2&r2=1.223

You are right. Actually this was a mismerge when we imported the 1.6.0
sources. Fixed in SVN.

Thanks for this report!

Frank
-- 
Dr.-Ing. Frank Mehnert    Sun Microsystems    http://www.sun.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://www.virtualbox.org/pipermail/vbox-dev/attachments/20090309/45ce0960/attachment.sig>