[vbox-dev] [PATCH] rdesktop-vrdp SEGVs with XCreateImage/XPutImage call in ui_desktop_restore()

[Taisuke Yamada]

Hi.

I've been experiencing frequent crash of rdesktop-vrdp on Debian
lenny, and I found it is due to obsolete XCreateImage call still
left in xwin.c.

Sometime in 2007, X.org has added extra sanity check for arguments to
XCreateImage, and now returns NULL for (now-invalid) XCreateImage call
in ui_desktop_restore(). This is causing SEGV in following XPutImage.

I have attached one-line patch to fix the problem, but I also found
rdesktop has exactly the same patch in 2007 (bee URL below):

-
http://rdesktop.cvs.sourceforge.net/viewvc/rdesktop/rdesktop/xwin.c?r1=1.222&r2=1.223

Best Regards,
Taisuke Yamada

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 258 bytes
Desc: OpenPGP digital signature
URL: <http://www.virtualbox.org/pipermail/vbox-dev/attachments/20090309/8ce72ea5/attachment.sig>