VirtualBox

Opened 8 years ago

Closed 8 years ago

#15871 closed defect (fixed)

Changeset 63628 - possible destroy of locked critical section?

Reported by: oldium Owned by:
Component: audio Version: VirtualBox 5.1.4
Keywords: Cc:
Guest type: other Host type: other

Description

In https://www.virtualbox.org/changeset/63628/vbox there is a change that moves RTCritSectLeave before audioMixerStreamDestroyInternal, but on the other hand the RTCritSectLeave will not be called when previous assignment to rc2 on line 1627 (rc2 = audioMixerSingRemoveStreamInternal...) fails. This looks like a bug - the unlock (RTCritSectLeave) should be called always if lock (RTCritSectEnter) succeeds.

Change History (1)

comment:1 by pentagonik, 8 years ago

Resolution: fixed
Status: newclosed

Thanks for spotting -- fixed in SVN and will be part of the next upcoming maintenance release as well.

Note: See TracTickets for help on using tickets.

© 2023 Oracle
ContactPrivacy policyTerms of Use