Crash when connecting to certain FTP servers -> fixed in svn

[fzylogic]

One particular FTP server (tummy.com) causes VirtualBox to crash when initiating a passive FTP connection.
It appears that the bug is triggered by the FTP server sending an ICMP Host Administratively Prohibited message after the connection is initiated. I've got a network dump attached that shows the packets.
The bug seems specific to NAT networking, but is not dependent on host OS (It's been verified in OSX 10.6-10.8 and on Debian Squeeze).

[fzylogic]

VBox.log

[fzylogic]

Uploaded a core dump here: ​http://karategerbil.com/vboxdumps/core.6055

[vasily Levchenko]

duplicate #10513

[Frank Mehnert]

Actually I'm not that sure that this is a duplicate of #10513. fzylogic, I cannot access your core dump, could you fix the permission problem?

[fzylogic]

Replying to frank:

Actually I'm not that sure that this is a duplicate of #10513. fzylogic, I cannot access your core dump, could you fix the permission problem?

All fixed. Sorry about that!

[fzylogic]

I finally got a debug build of VBox put together and got the following info out of gdb:

#0 0x00007f8dffcaca08 in send_icmp_to_guest (pData=0x7f8e003edd90, buff=0x2573c20 "E", len=88, addr=0x7f8dfc73da10)

at /root/vbox/src/VBox/Devices/Network/slirp/socket.c:1369

1369 Assert(m != NULL);

[Frank Mehnert]

Great! Which source tree is that, VBox 4.1.14 or from the subversion repository on this server? If the latter, which revision?

[fzylogic]

That's straight out of subversion as of a couple of hours ago.

[fzylogic]

revision 41182

[vasily Levchenko]

Replying to fzylogic:

Thanks for reporting and testing.

[Frank Mehnert]

The fix is in r41198. Please verify.

[fzylogic]

Replying to frank:

The fix is in r41198. Please verify.

Looks like that did the trick! I can now get a file listing from that ftp server without a crash.

[Frank Mehnert]

Fix is part of VirtualBox 4.1.16.