VirtualBox

Ticket #15871 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Changeset 63628 - possible destroy of locked critical section?

Reported by: oldium Owned by:
Component: audio Version: VirtualBox 5.1.4
Keywords: Cc:
Guest type: other Host type: other

Description

In https://www.virtualbox.org/changeset/63628/vbox there is a change that moves RTCritSectLeave before audioMixerStreamDestroyInternal, but on the other hand the RTCritSectLeave will not be called when previous assignment to rc2 on line 1627 (rc2 = audioMixerSingRemoveStreamInternal...) fails. This looks like a bug - the unlock (RTCritSectLeave) should be called always if lock (RTCritSectEnter) succeeds.

Change History

comment:1 Changed 4 years ago by pentagonik

  • Status changed from new to closed
  • Resolution set to fixed

Thanks for spotting -- fixed in SVN and will be part of the next upcoming maintenance release as well.

Note: See TracTickets for help on using tickets.

www.oracle.com
ContactPrivacy policyTerms of Use