discard and nonrotational errors => fixed in svn

[James Lucas]

Two errors I have found when setting the new storage options for SSD like properties (trim and non-rotational support).

1) When using --discard in a VBoxManage storeageattach it always results in discard="true" being set in the machines .vbox file, the flag on|off is ignored

VBoxManage storageattach "Staff Desktop" --storagectl "SATA Controller" --port 0 --device 0 --discard off
or even
VBoxManage storageattach "Staff Desktop" --storagectl "SATA Controller" --port 0 --device 0 --discard ignorewhateverIsay

results in discard being enabled.

2) VBoxManage storageattach --nonrotational flag is not parsed and returns an error

$  VBoxManage storageattach "Staff Desktop" --storagectl "SATA Controller" --port 0 --device 0 --nonrotational on
VBoxManage: error: Invalid --nonrotational argument 'on'
$  VBoxManage storageattach "Staff Desktop" --storagectl "SATA Controller" --port 0 --device 0 --nonrotational off
VBoxManage: error: Invalid --nonrotational argument 'off'

VBoxSVC.log errors are always the same even the successful enabling of discard shows the same errors.

[aeichner]

Thanks for the report, will be fixed in the next maintenance release.

[Frank Mehnert]

Fixed in 4.2.2.