[vbox-dev] Fix for nocrt vector implementation

Andreas Löffler andreas.loeffler at oracle.com
Thu Dec 15 13:39:53 GMT 2022


Hello Martin,

thanks for reporting this and for the fix! I'll take care of it.


-- 
Kind regards / Mit freundlichen Grüßen

******************************************************************
Andreas Löffler | VirtualBox Engineering
Principal Software Engineer | Oracle Virtualization

Oracle Global Services Germany GmbH
Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRB 246209
Geschäftsführer: Ralf Herrmann

Green Oracle <http://www.oracle.com/commitment> 
<http://www.oracle.com/commitment%3e>; Oracle is committed to developing 
practices and products that help protect the environment




On 15/12/2022 13:39, Martin Fleisz via vbox-dev wrote:
> The patch below fixes an issue with the nocrt vector's != operator which
> is commonly used in iteration loops.
> 
> I'm submitting this patch under the MIT license.
> 
> Best regards,
> 
> Martin Fleisz
> Thincast Technologies GmbH
> 
> 
> diff --git include/iprt/nocrt/vector include/iprt/nocrt/vector
> index 607a75097d3..925f9e1ac18 100644
> --- include/iprt/nocrt/vector
> +++ include/iprt/nocrt/vector
> @@ -154,7 +154,7 @@ namespace std
>       inline bool operator!=(const RTCNoCrtVectorIterator<a_TypeLeft,
> a_Container> &a_rLeft,
>                              const RTCNoCrtVectorIterator<a_TypeRight,
> a_Container> &a_rRight) RT_NOEXCEPT
>       {
> -        return a_rLeft.getConst() == a_rRight.getConst();
> +        return a_rLeft.getConst() != a_rRight.getConst();
>       }
>   
>       template<typename a_TypeLeft, typename a_TypeRight, class a_Container>
> 
> _______________________________________________
> vbox-dev mailing list
> vbox-dev at virtualbox.org
> https://www.virtualbox.org/mailman/listinfo/vbox-dev



More information about the vbox-dev mailing list