[vbox-dev] CUE support: BINARY endianess

[Dennis Borde]

Hi everybody,

playing audio CD images (CUE/BIN) does not work (at least on Windows 10
host and Windows XP guest). However, I guess it is a general issue with the
handling of endianess.

According to "
https://www.gnu.org/software/ccd2cue/manual/html_node/FILE-_0028CUE-Command_0029.html#FILE-_0028CUE-Command_0029
"
BINARY is always little endian and
MOTOROLA is always big endian.

In "VirtualBox-6.1.22/src/VBox/Storage/CUE.cpp" in the function "cueRead"
it swapps the bytes in case it is little endian.
Also the keyword MOTOROLA for big endian is not defined, although there is
code for it.

The following patch should fix it. Unfortunately, I do not have a running
build environment to test it. Maybe someone of you has the chance.

238a239
>     {RT_STR_TUPLE("MOTOROLA"),   CUEKEYWORD_MOTOROLA},
1535c1536
<             && pThis->fLittleEndian)
---
>             && !pThis->fLittleEndian)

Best regards
Dennis
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.virtualbox.org/pipermail/vbox-dev/attachments/20210715/714427f1/attachment.html>