[vbox-dev] [ PATCH] Fix crash on startup under Wayland

[Hans de Goede]

Hi,

On 6/8/20 5:11 PM, Sérgio Basto wrote:
> Hi,
> 
> On Mon, 2020-06-08 at 10:50 +0200, Frank Batschulat wrote:
>> This has been fixed in the new release 6.1.10
> 
> Can you please show me where is the code in SVN ?
> 
> Unfortunately seems that svn source code is not updated for 2 months (
> https://www.virtualbox.org/browser/vbox/ ) so it is more difficult to
> follow the modifications .

There is a new RTEnvSet call in this bit:

#ifdef VBOX_WS_X11
         /* Make sure multi-threaded environment is safe: */
         if (!MakeSureMultiThreadingIsSafe())
             break;
         /* Force using Qt platform module 'xcb', we have X11 specific code: */
         RTEnvSet("QT_QPA_PLATFORM", "xcb");
#endif /* VBOX_WS_X11 */

of src/VBox/Frontends/VirtualBox/src/main.cpp

Regards,

Hans



>> On Wed, 20 May 2020 12:47:47 +0200, Frank Batschulat
>> <frank.batschulat at oracle.com> wrote:
>>
>>> Testbuilds with the fix can be downloaded now:
>>>
>>> for Trunk:
>>> https://www.virtualbox.org/download/testcase/VirtualBox-6.1.97-138092-Linux_amd64.run
>>>
>>> for 6.1.X:
>>> https://www.virtualbox.org/download/testcase/VirtualBox-6.1.9-138068-Linux_amd64.run
>>>
>>> or directly from: https://www.virtualbox.org/wiki/Testbuilds
>>> for Trunk any Linux 64-bit .run installer with build >= r138057 and
>>> for
>>> 6.1.X any build >= r138068
>>>
>>> On Thu, 14 May 2020 14:43:01 +0200, Frank Batschulat
>>> <frank.batschulat at oracle.com> wrote:
>>>
>>>> Hans, I have filed the following bug to track this:
>>>>
>>>> [Oracle VM VirtualBox] #19583: GUI crashes when using Qt on
>>>> Xwayland
>>>> sessions
>>>> https://www.virtualbox.org/ticket/19583
>>>>
>>>> the possible fix for this is still being discussed internally.
>>>>
>>>> On Tue, 07 Apr 2020 14:00:47 +0200, Hans de Goede <
>>>> hdegoede at redhat.com>
>>>> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> I noticed that with a default Fedora 32 workstation install
>>>>> (default
>>>>> GNOME3 on
>>>>> Wayland session) VirtualBox crashes immediately at startup.
>>>>> The
>>>>> problem is that
>>>>> QT5 now defaults to the Wayland backend and VirtualBox assumes
>>>>> the X11
>>>>> backend
>>>>> is used and makes a bunch of unchecked X11 calls which cause
>>>>> NULL
>>>>> pointer derefs.
>>>>>
>>>>> The attached patch is a simple fix which fixes this by setting
>>>>> the QT
>>>>> backend
>>>>> back to X11.
>>>>>
>>>>> As usual, the patch is released under the MIT license.
>>>>>
>>>>> Regards,
>>>>>
>>>>> Hans
>>
>>