[vbox-dev] [PATCH] drm vbox_ttm build fix

[Frank Batschulat]

Yeah, right. I didn't liked it the current way either.
I'll correct the include path in trunk, 6.x and 5.x soon,
issue 3) is the red herring here.

On Sat, 19 Oct 2019 13:57:10 +0200, Gianfranco Costamagna  
<locutusofborg at debian.org> wrote:

>  Hello Frank,
> src/VBox/Additions/linux/drm/vbox_drv.h:#include <drm/ttm/ttm_bo_api.h>
> src/VBox/Additions/linux/drm/vbox_drv.h:#include  
> <drm/ttm/ttm_bo_driver.h>
> src/VBox/Additions/linux/drm/vbox_drv.h:#include  
> <drm/ttm/ttm_placement.h>
> src/VBox/Additions/linux/drm/vbox_drv.h:#include <drm/ttm/ttm_memory.h>
> src/VBox/Additions/linux/drm/vbox_drv.h:#include <drm/ttm/ttm_module.h>
> src/VBox/Additions/linux/drm/vbox_ttm.c:#include <ttm/ttm_page_alloc.h>
>
> while the workaround might work for you, it has 2+ issues:1) it makes  
> the includes not consistent across the code2) it is not what kernel  
> developers suggest to do3) breaks other build systems using standard  
> tools to build kernel modules(e.g. Debian dkms, and Yocto builds)
> can you please also apply the patch?
> thanks!
>
>
>     Il giovedì 17 ottobre 2019, 13:30:38 CEST, Frank Batschulat  
> <frank.batschulat at oracle.com> ha scritto:
> Gianfranco, pls. refer to
>
> https://www.virtualbox.org/ticket/18869
>
> On 17.10.19 12:51, Gianfranco Costamagna wrote:
>> Hello, this patch was already acked but seems to have missed the 6.0.14  
>> release
>> Bug-Debian: https://bugs.debian.org/934483
>> Last-Update: 2019-08-21
>>
>> --- virtualbox-6.0.10-dfsg.orig/src/VBox/Additions/linux/drm/vbox_ttm.c
>> +++ virtualbox-6.0.10-dfsg/src/VBox/Additions/linux/drm/vbox_ttm.c
>> @@ -33,7 +33,7 @@
>>     *          Michael Thayer <michael.thayer at oracle.com>
>>     */
>>    #include "vbox_drv.h"
>> -#include <ttm/ttm_page_alloc.h>
>> +#include <drm/ttm/ttm_page_alloc.h>
>>
>>    #if LINUX_VERSION_CODE < KERNEL_VERSION(3, 18, 0) &&  
>> !defined(RHEL_72)
>>    #define PLACEMENT_FLAGS(placement) (placement)
>>
>>
>>
>> MIT licensed, and fixes a build failure with some new kernels, by  
>> unifying the include header in all the places
>> thanks
>> Gianfranco
>>
>>
>> _______________________________________________
>> vbox-dev mailing list
>> vbox-dev at virtualbox.org
>> https://www.virtualbox.org/mailman/listinfo/vbox-dev
>>
>
>
>
>


-- 
frankB

Oracle Virtualbox Development