[vbox-dev] [PATCH 2nd resend] VBoxServiceAutoMount: Change Linux mount code to use

Sérgio Basto sergio at serjux.com
Mon May 6 15:35:08 GMT 2019


On Fri, 2019-05-03 at 23:40 +0200, Knut St. Osmundsen wrote:
> Hi Sérgio,
> the patch undoes the mount tagging I added in 6.0 to distinguish
> between
> user mounted and automatically mounted shares.  

I don't have knowledge to give an opinion, I have to check if
automatically mounted shares, still working ... 

I try to use the hat of packager and tester, not the coder. 
To test it correctly I need to be sure where code of 
Additions/common/VBoxService/VBoxServiceAutoMount.cpp is used .

This is only guest-additions part ? or I do need rebuild VirtualBox
server ? is this code used by vboxsf.ko kernel module ? 

I.e to test modifications on VBoxServiceAutoMount.cpp, we just need
rebuild guest-additions ? it is safe think that ? 

Many thanks 

> Further, it removes
> vbsfmount_complete code we need for updating mtab on some really old
> additions we still care a little bit about.  I'm not entirely sure if
> removing the retry code around line 486 is a bad thing, but I've just
> left it there as I assume Andy (or someone) had a good reason for it
> once upon a time.
> Finally, does the libc or kernel mount() implementation somehow
> invoke
> the /sbin/mount.vboxsf helper tool?  Please point me to the code
> causing
> this, because our vboxsf sources does not parse any parameter
> strings,
> it is binary struct only.

(copied from the other email)
AFAIK with this patch we don't need /sbin/mount.vboxsf helper tool

mount -t vboxsf works and we will autoload vboxsf.ko , i.e we don't
need modprobe vboxsf at boot anymore  

> Kind regards, bird.
> On 2019-05-02 6:56 PM, Sérgio Basto wrote:
> > Hi,
> > Please accept this patch we are using on Fedora packages and it is
> > working with in-kernel and not in-kernel (el7) modules
> > 
> > I'm OK with MIT license for this patch
> > Best regards
> > _______________________________________________
> > vbox-dev mailing list
> > vbox-dev at virtualbox.org
> > https://www.virtualbox.org/mailman/listinfo/vbox-dev
> _______________________________________________
> vbox-dev mailing list
> vbox-dev at virtualbox.org
> https://www.virtualbox.org/mailman/listinfo/vbox-dev
Sérgio M. B.

More information about the vbox-dev mailing list