[vbox-dev] [PATCH] Fix compilation with LibreSSL <2.7.0

valdis.kletnieks at vt.edu valdis.kletnieks at vt.edu
Tue Feb 12 02:35:14 UTC 2019


On Tue, 12 Feb 2019 02:22:07 +0200, Stefan Strogin said:
> Could somebody review the patch please?

> > +# if (OPENSSL_VERSION_NUMBER >= 0x10100000 && !defined(LIBRESSL_VERSION_NUMBER)) || LIBRESSL_VERSION_NUMBER >= 0x2070000f

Wow. Took me some staring before I realized there were two different
SSL_VERSION_NUMBER in that &&.

Having said that, if the build is using OpenSSL, under what case would LibreSSL version
be defined at all? And if both *were* included, wouldn't the build die of other issues?

Maybe it's enough to say

#if (openssl >= openssl_vers) || (LibreSSL >= Libre_version)  

?


More information about the vbox-dev mailing list