[vbox-dev] when you migrate to git ? Re: Fixes for upcoming Linux 5.1 kernel

Sérgio Basto sergio at serjux.com
Mon Feb 11 23:35:16 UTC 2019


On Mon, 2019-02-11 at 17:36 +0100, Michael Thayer wrote:
> Hello Sérgio,
> 
> https://www.virtualbox.org/changeset/77198/vbox
> 
> Nothing there that wasn't already in the patch though.

Hi, 
Thanks.
I prefer use the official (upstream) patch to be sure that I'm using
the correct patch .

I was not lucky, yesterday last commit that I got from svn was 77197
(one less this one) , so I couldn't found the commit in svn meanwhile
the project svn2togithub was closed.
So I decide continue svn2togithub of virtualbox as svn2togithub author
suggest and today [1] because is much more easier get and find the
patches, for example [2] .

[1] https://github.com/sergiomb2/virtualbox
[2] https://github.com/sergiomb2/virtualbox/commits/master/trunk/src/VBox/Runtime/r0drv 

> Regards
> Michael
> 
> 11.02.19 16:41, Sérgio Basto wrote:
> > On Thu, 2019-02-07 at 16:19 +0100, Michael Thayer wrote:
> > > Thank you Valdis, finally committed!  It should show up in public
> > > Subversion soon.
> > 
> > when or where ? please
> > 
> > Thanks
> > 
> > > Regards
> > > Michael
> > > 
> > > 29.01.19 01:05, valdis.kletnieks at vt.edu wrote:
> > > > A commit landed in linux-next (which will land in 5.1):
> > > > 
> > > > commit ae5d11d206fce924efcaa8127ffdbdb60c660d7a
> > > > Author: Michael S. Tsirkin <mst at redhat.com>
> > > > Date:   Thu Jan 24 08:54:07 2019 -0500
> > > > 
> > > >     arch: move common mmap flags to linux/mman.h
> > > >     
> > > >     Now that we have 3 mmap flags shared by all architectures,
> > > >     let's move them into the common header.
> > > > 
> > > > This broke the build because MAP_SHARED wasn't defined.
> > > > 
> > > >  CC
> > > > [M]  /usr/share/virtualbox/src/vboxhost/vboxdrv/r0drv/linux/mem
> > > > user
> > > > kernel-r0drv-linux.o
> > > > /usr/share/virtualbox/src/vboxhost/vboxdrv/r0drv/linux/memobj-
> > > > r0drv-linux.c: In function ?rtR0MemObjLinuxDoMmap?:
> > > > /usr/share/virtualbox/src/vboxhost/vboxdrv/r0drv/linux/memobj-
> > > > r0drv-linux.c:215:58: error: ?MAP_SHARED? undeclared (first use
> > > > in
> > > > this function); did you mean ?VM_SHARED??
> > > >   215 |         ulAddr = vm_mmap(NULL, R3PtrFixed, cb,
> > > > fLnxProt,
> > > > MAP_SHARED | MAP_ANONYMOUS | MAP_FIXED, 0);
> > > >       |                                                        
> > > >   ^~
> > > > ~~~~~~~~
> > > >       |                                                        
> > > >   VM
> > > > _SHARED
> > > > /usr/share/virtualbox/src/vboxhost/vboxdrv/r0drv/linux/memobj-
> > > > r0drv-linux.c:215:58: note: each undeclared identifier is
> > > > reported
> > > > only once for each function it appears in
> > > > make[3]: *** [scripts/Makefile.build:277:
> > > > /usr/share/virtualbox/src/vboxhost/vboxdrv/r0drv/linux/memobj-
> > > > r0drv-linux.o] Error 1
> > > > 
> > > > --- vboxdrv/r0drv/linux/the-linux-kernel.h.dist	2019-01-28
> > > > 19:01:50.615246073 -0500
> > > > +++ vboxdrv/r0drv/linux/the-linux-kernel.h	2019-01-28
> > > > 19:01:24.495292846 -0500
> > > > @@ -128,6 +128,9 @@
> > > >  # include <linux/cpu.h>
> > > >  # include <linux/notifier.h>
> > > >  #endif
> > > > +#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 1, 0)
> > > > +# include <uapi/linux/mman.h>
> > > > +#endif
> > > >  /* For the basic additions module */
> > > >  #include <linux/pci.h>
> > > >  #include <linux/delay.h>
> > > > 
> > > > _______________________________________________
> > > > vbox-dev mailing list
> > > > vbox-dev at virtualbox.org
> > > > https://www.virtualbox.org/mailman/listinfo/vbox-dev
> > > > 
> > > 
> > > _______________________________________________
> > > vbox-dev mailing list
> > > vbox-dev at virtualbox.org
> > > https://www.virtualbox.org/mailman/listinfo/vbox-dev
> 
> 
-- 
Sérgio M. B.



More information about the vbox-dev mailing list