[vbox-dev] kernel 5.2 build fix [PATCH]

Frank Batschulat frank.batschulat at oracle.com
Mon Aug 26 10:14:46 GMT 2019


On Mon, 26 Aug 2019 12:02:26 +0200, Gianfranco Costamagna  
<locutusofborg at debian.org> wrote:

> Hello, for some reasons, see [1] virtualbox doesn't build its kernel  
> modules correctly on some configurations...The following patch fixes the  
> issue
> +--- virtualbox-6.0.10-dfsg.orig/src/VBox/Additions/linux/drm/vbox_ttm.c
> ++++ virtualbox-6.0.10-dfsg/src/VBox/Additions/linux/drm/vbox_ttm.c
> +@@ -33,7 +33,7 @@
> +  *          Michael Thayer <michael.thayer at oracle.com>
> +  */
> + #include "vbox_drv.h"
> +-#include <ttm/ttm_page_alloc.h>
> ++#include <drm/ttm/ttm_page_alloc.h>
> +
> + #if LINUX_VERSION_CODE < KERNEL_VERSION(3, 18, 0) && !defined(RHEL_72)
> + #define PLACEMENT_FLAGS(placement) (placement)
>
> please apply(you are not supposed to think that kernel is exporting  
> -Iinclude/drm directory, and in all the other places it is not included  
> that way)
>
> see for comparison:src/VBox/Additions/linux/drm/vbox_drv.h:#include  
> <drm/ttm/ttm_bo_api.h>
> src/VBox/Additions/linux/drm/vbox_drv.h:#include  
> <drm/ttm/ttm_bo_driver.h>
> src/VBox/Additions/linux/drm/vbox_drv.h:#include  
> <drm/ttm/ttm_placement.h>
> src/VBox/Additions/linux/drm/vbox_drv.h:#include <drm/ttm/ttm_memory.h>
> src/VBox/Additions/linux/drm/vbox_drv.h:#include <drm/ttm/ttm_module.h>
>
> MIT licensed, as usual
> G.
> [1] https://bugs.debian.org/934483

Thanks, yeah we where discussing this issue just lately, I had the same  
fix intent.

I'll see where we are with this and fix this in Trunk and backport to the  
6.0 branch.
I'll file a back for tracking purposes and let you know.

cheers
-- 
frankB

Oracle Virtualbox Development



More information about the vbox-dev mailing list