[vbox-dev] Patch to bug #17884

[Michael Kielstra]

You're probably right.  At least we're aware it's an issue that might come up if GNOME terminal is updated again and loses the -x option permanently.

Michael

-----Original Message-----
From: Michael Thayer <michael.thayer at oracle.com> 
Sent: Tuesday, 24 July 2018 12:14
To: Michael Kielstra <pmkielstra at outlook.com>
Cc: VirtualBox developer's list <vbox-dev at virtualbox.org>
Subject: Re: [vbox-dev] Patch to bug #17884

Looking at the source code of GNOME Terminal in CentOS 4, it does not seem to recognise the "--" option.  So we would need at the least to support both forms, but as long as the old form works, I would tend to postpone the change and work on more current things.

Regards
Michael

24.07.2018 12:06, Michael Thayer wrote:> It seems I accidentally took the mailing list off CC.  Adding it back
> on.  That means that it will break for GNOME Terminal in than 2012, 
> but not 2004.  CentOS 4 GNOME Terminal was last updated in 2005, so it 
> needs checking how that will be affected.
> 
> Regards
> Michael
> 
> 23.07.2018 18:47, Michael Kielstra wrote:
>> Dear Michael,
>>
>> It works with 12.10, but not with 4.10.
>>
>> Michael
>>
>> -----Original Message-----
>> From: Michael Kielstra
>> Sent: Monday, 23 July 2018 17:09
>> To: 'Michael Thayer' <michael.thayer at oracle.com>
>> Subject: RE: [vbox-dev] Patch to bug #17884
>>
>> Dear Michael,
>>
>> It's tested on Ubuntu 18.04, but not on older guests.  I'll try it on Ubuntu 12.10 and get back to you.  I don't forsee many problems -- according to POSIX, all we're doing is becoming more standards-compliant.  On the other hand, standards-compliance has never been an excuse for working code *cough* IE *cough*...
>>
>> Michael
>>
>> -----Original Message-----
>> From: Michael Thayer <michael.thayer at oracle.com>
>> Sent: Monday, 23 July 2018 14:14
>> To: Michael Kielstra <pmkielstra at outlook.com>
>> Subject: Re: [vbox-dev] Patch to bug #17884
>>
>> Hello Michael,
>>
>> Thank you for the patch.  You wrote that it is tested - did you also test it on older guests?  We support guests going back to *EL3 (admittedly I don't thin that the automatic install script actually works on EL3, but it does on many more recent but still old guests), so this sort of thing does need a bit of checking.
>>
>> Regards
>> Michael
>>
>> 23.07.2018 09:51, Michael Kielstra wrote:
>>> Dear All,
>>>
>>>  
>>>
>>> I'm really, really new to this, so I apologise in advance if I break 
>>> any protocols or make any mistakes.  I reported bug #17844 yesterday 
>>> (the Linux Guest Additions install script uses -x instead of -- as 
>>> the option to pass a command to a newly instantiated terminal), and 
>>> attach a tested, MIT-licensed, patch that fixes it.  Plus, it brings 
>>> us further into the realm of POSIX-based design, since -- is, I 
>>> believe, the recommended switch for "treat the rest of the line as a command".
>>> Thank you for taking a look.
>>>
>>>
>>>
>>> _______________________________________________
>>> vbox-dev mailing list
>>> vbox-dev at virtualbox.org
>>> https://www.virtualbox.org/mailman/listinfo/vbox-dev
>>>
>>
>> --
>> Michael Thayer | VirtualBox engineer
>> ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
>>
>> ORACLE Deutschland B.V. & Co. KG
>> Hauptverwaltung: Riesstraße 25, D-80992 München
>> Registergericht: Amtsgericht München, HRA 95603
>>
>> Komplementärin: ORACLE Deutschland Verwaltung B.V.
>> Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister 
>> der Handelskammer Midden-Nederland, Nr. 30143697
>> Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
>>
> 
> 
> 
> _______________________________________________
> vbox-dev mailing list
> vbox-dev at virtualbox.org
> https://www.virtualbox.org/mailman/listinfo/vbox-dev
> 

--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher