[vbox-dev] [Trunk] Run-time crash because of r72042

Kalogrianitis Socratis socratisk at gmail.com
Sun Apr 29 18:12:17 UTC 2018


It's a long weekend and I don't want to forget it, so here it goes...

I was on r72026 and updated my local copy to r72051. Compiling and running the latest r72051 from the trunk comes back with no errors, but as soon as you launch VirtualBox, kaboom, it disappears.

I tracked down the culprit (by bisecting the builds) to the changes in r72042 (https://www.virtualbox.org/changeset/72042/vbox). Every revision after that crashes, including the latest 72051. Patching the current trunk and undoing in a sense r72042, returns everything back to normal.


Index: src/VBox/Frontends/VirtualBox/src/selector/UIToolsPaneMachine.cpp
===================================================================
--- src/VBox/Frontends/VirtualBox/src/selector/UIToolsPaneMachine.cpp	(revision 72051)
+++ src/VBox/Frontends/VirtualBox/src/selector/UIToolsPaneMachine.cpp	(working copy)
@@ -201,9 +201,10 @@
 {
     /* Do we need translation after that? */
     const bool fTranslationRequired =  (!pItem &&  m_pItem)
-                                    || ( pItem && !m_pItem)
-                                    || (!pItem->accessible() &&  m_pItem->accessible())
-                                    || ( pItem->accessible() && !m_pItem->accessible());
+                                    || ( pItem && !m_pItem);
+//                                     || ( pItem && !m_pItem)
+//                                     || (!pItem->accessible() &&  m_pItem->accessible())
+//                                     || ( pItem->accessible() && !m_pItem->accessible());
 
     /* Remember new item: */
     m_pItem = pItem;
===================================================================

HOST: 10.9.5
BUILD: From trunk.

When you come back after 1/May, I'll be on IRC if you want details, crash logs, the works.



PS. How on earth you revert a *single* file only, to a specific revision without touching the rest? Everything I tried seemed to make it, but the file didn't actually revert to an earlier revision. N00b here ;)


More information about the vbox-dev mailing list