[vbox-dev] [PATCH resend] VBoxGuest.h Fix VBGL_IOCTL_WAIT_FOR_EVENTS definition

Michael Thayer michael.thayer at oracle.com
Tue Oct 3 13:34:49 GMT 2017


Hello Hans,

Terribly sorry.  I admit that I never got round to looking at this, but
it does looks very sensible.  Just doing a sanity build now before I
push it to our internal repository, and I will make it publicly visible
as soon after that as I have a stable Internet connection.

Regards
Michael

03.10.2017 09:50, Hans de Goede wrote:
> The size argument to VBGL_IOCTL_CODE_SIZE should be
> VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE. This fixes VBGL_IOCTL_WAIT_FOR_EVENTS
> always failing with EINVAL. Which in turn fixes seamless mode not
> working under Linux.
> 
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> ---
>  include/VBox/VBoxGuest.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/VBox/VBoxGuest.h b/include/VBox/VBoxGuest.h
> index 28313e4e..9283a15d 100644
> --- a/include/VBox/VBoxGuest.h
> +++ b/include/VBox/VBoxGuest.h
> @@ -387,7 +387,7 @@ typedef struct VBGLIOCLOG
>   * Wait for a VMMDev host event notification.
>   * @{
>   */
> -#define VBGL_IOCTL_WAIT_FOR_EVENTS                  VBGL_IOCTL_CODE_SIZE(10, VBGL_IOCTL_GET_VMMDEV_IO_INFO_SIZE)
> +#define VBGL_IOCTL_WAIT_FOR_EVENTS                  VBGL_IOCTL_CODE_SIZE(10, VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE)
>  #define VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE             sizeof(VBGLIOCWAITFOREVENTS)
>  #define VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE_IN          sizeof(VBGLIOCWAITFOREVENTS)
>  #define VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE_OUT         RT_UOFFSET_AFTER(VBGLIOCWAITFOREVENTS, u.Out)
> 

-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher



More information about the vbox-dev mailing list