[vbox-dev] rflags missing in debug core dump

[samuele.defrancesco]

Hi Ram,

Thanks for the quick answer, yes MIT Licensing is ok. Glad I could help!

Regards,
   Sam

On 07/06/2016 11:45, Ramshankar wrote:
> Hi,
>
> You're right, the rflags is missing in the dump. The patch looks good.
>
> Please confirm if you're releasing this patch under MIT so we may 
> apply it right away.
>
> Thanks & Regards,
> Ram.
>
>
> On 06/06/2016 02:49 PM, samuele.defrancesco wrote:
>> Hi,
>>
>> I noticed the standardized CPU dump struct does not contain rflags 
>> register field. If I am right, the following patch should fix the 
>> problem.
>>
>> Index: include/VBox/vmm/dbgfcorefmt.h
>> ===================================================================
>> --- include/VBox/vmm/dbgfcorefmt.h    (revision 61473)
>> +++ include/VBox/vmm/dbgfcorefmt.h    (working copy)
>> @@ -48,7 +48,7 @@
>>  /** DBGCORECOREDESCRIPTOR::u32Magic. */
>>  #define DBGFCORE_MAGIC          UINT32_C(0xc01ac0de)
>>  /** DBGCORECOREDESCRIPTOR::u32FmtVersion. */
>> -#define DBGFCORE_FMT_VERSION    UINT32_C(0x00010003)
>> +#define DBGFCORE_FMT_VERSION    UINT32_C(0x00010004)
>>
>>  /**
>>   * An x86 segment selector.
>> @@ -100,6 +100,7 @@
>>      uint64_t            rip;
>>      uint64_t            rsp;
>>      uint64_t            rbp;
>> +    uint64_t            rflags;
>>      DBGFCORESEL         cs;
>>      DBGFCORESEL         ds;
>>      DBGFCORESEL         es;
>> Index: src/VBox/VMM/VMMR3/DBGFCoreWrite.cpp
>> ===================================================================
>> --- src/VBox/VMM/VMMR3/DBGFCoreWrite.cpp    (revision 61473)
>> +++ src/VBox/VMM/VMMR3/DBGFCoreWrite.cpp    (working copy)
>> @@ -344,6 +344,7 @@
>>      pDbgfCpu->rip             = pCtx->rip;
>>      pDbgfCpu->rsp             = pCtx->rsp;
>>      pDbgfCpu->rbp             = pCtx->rbp;
>> +    pDbgfCpu->rflags          = pCtx->rflags.u;
>>      DBGFCOPYSEL(pDbgfCpu->cs, pCtx->cs);
>>      DBGFCOPYSEL(pDbgfCpu->ds, pCtx->ds);
>>      DBGFCOPYSEL(pDbgfCpu->es, pCtx->es);
>>
>>
>> Regards,
>>     Sam
>> _______________________________________________
>> vbox-dev mailing list
>> vbox-dev at virtualbox.org
>> https://www.virtualbox.org/mailman/listinfo/vbox-dev
>