[vbox-dev] [PATCH] Use QMetaObject::invokeMethod instead of QTimer::singleShot(0, ...)

Klaus Espenlaub klaus.espenlaub at oracle.com
Mon May 4 11:37:55 UTC 2015


On 02.05.2015 05:32, Alex Henrie wrote:
> 2015-03-31 7:51 GMT-06:00 Sergey Dubov <sergey.dubov at oracle.com>:
>> Interesting finding, thank you.
>> We will update that stuff after testing when will find time for it.
> It's been over a month and this patch has still not been applied. I
> didn't think it would be controversial; why the delay?

Because we have far more work to do than time to do it, especially 
during beta testing... besides, you said yourself that there isn't all 
that much benefit (readability is always a matter of taste, and I don't 
think QTimer::singleShot(0, ...) is used in places where using the 
replacement could have a noticeable performance impact). Correct me if 
I'm wrong.

It definitely stays in the contribution queue.


> -Alex

More information about the vbox-dev mailing list