[vbox-dev] Fix to #13801

[a.urakov at drweb.com]

Hi Klaus,

thank you!

Regards,
Alexander

11.02.2015 16:42, Klaus Espenlaub пишет:
> Hi Alexander,
>
> this one definitely looks correct, and I believe that your guess is 
> ultimately correct (even though I don't think the code intentionally 
> preserved the no longer needed lock)... will go into the code ASAP.
>
> Klaus
>
> On 30.01.2015 15:53, a.urakov at drweb.com wrote:
>> Hello!
>>
>> We would like to contribute to VirtualBox under MIT license. We send 
>> our changes to fix bug described at 
>> https://www.virtualbox.org/ticket/13801 .
>>
>> The idea is that there is no need to hold write lock on parent medium 
>> to change its locking type. In current version we unlock all session 
>> locked list first and only then we update locking type. But in this 
>> case only element of /pMediumLockList/ is changed, not /Medium/ 
>> object. May be parent write-locking code left after old version, 
>> where parent lock type updating looked like this (version /3.1.8/):
>>
>> ComObjPtr<Medium> parent = pMedium->getParent();
>> /* make the relock atomic */
>> AutoWriteLock parentLock (parent);
>> rc = parent->UnlockWrite(NULL);
>> AssertComRC(rc);
>> rc = parent->LockRead(NULL);
>> AssertComRC(rc);
>>
>> Regards,
>> Alexander
>>
>>
>>
>> _______________________________________________
>> vbox-dev mailing list
>> vbox-dev at virtualbox.org
>> https://www.virtualbox.org/mailman/listinfo/vbox-dev
>
> -- 
> Oracle <http://www.oracle.com>
> Klaus Espenlaub | Software Development Director
> Phone: +49 7151 60405205 <tel:+49%207151%2060405205>
> Oracle VM VirtualBox
>
> ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | 71384 Weinstadt
>
> ORACLE Deutschland B.V. & Co. KG
> Hauptverwaltung: Riesstr. 25, D-80992 München
> Registergericht: Amtsgericht München, HRA 95603
> Geschäftsführer: Jürgen Kunz
>
> Komplementärin: ORACLE Deutschland Verwaltung B.V.
> Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
> Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher
>
> Green Oracle <http://www.oracle.com/commitment> Oracle is committed to 
> developing practices and products that help protect the environment
>
>
> _______________________________________________
> vbox-dev mailing list
> vbox-dev at virtualbox.org
> https://www.virtualbox.org/mailman/listinfo/vbox-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.virtualbox.org/pipermail/vbox-dev/attachments/20150211/fb6c4f91/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/gif
Size: 658 bytes
Desc: not available
URL: <http://www.virtualbox.org/pipermail/vbox-dev/attachments/20150211/fb6c4f91/attachment.gif>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/gif
Size: 356 bytes
Desc: not available
URL: <http://www.virtualbox.org/pipermail/vbox-dev/attachments/20150211/fb6c4f91/attachment-0001.gif>