[vbox-dev] FreeBSD + VirtualBOX + USB support

[Alexander Eichner]

Hi Hans Petter,

thanks for the contribution! Before we can apply it we need you to sign the Contributors Agreement
or state that the changes are under the MIT license.

Regards,
Alexander Eichner

----- Original Message -----
From: hps at selasky.org
To: klaus.espenlaub at oracle.com, vbox-dev at virtualbox.org
Sent: Friday, November 28, 2014 5:42:48 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
Subject: Re: [vbox-dev] FreeBSD + VirtualBOX + USB support

On 11/28/14 10:06, Klaus Espenlaub wrote:
> Hi Hans Petter,
>
> On 28.11.2014 09:46, Hans Petter Selasky wrote:
>> Hi,
>>
>> I see that VirtualBOX has made some changes to the USB APIs recently,
>> not updating all the USB backends. Next time you plan to change
>> anything, can the VirtualBOX USB developers drop me an e-mail, so we
>> don't have this situation again!
>
> Sorry that there have been some inconvenience, but it's unavoidable to
> temporarily break a few things during the ongoing USB3/xHCI work on trunk.
>
> The USB backend changes aren't finalized, there might be more to come.
> We have a few cases which don't work (e.g. support for UASP), and it's
> hard to predict how far the necessary changes have to ripple through.
>
>> Thank you!
>>
>> Who can accept and review USB patches for the FreeBSD USB backend?
>
> Easiest way is sending them to this mailing list, we'll apply them as
> quickly as possible.
>
> Cheers,
> Klaus

Hi,

The attached patch fixes some issues with FreeBSD and the VirtualBOX USB 
backend:

Issue #1)
Change wrong callback area size from "sizeof(PUSBPROXYDEVFBSD)" into 
"sizeof(USBPROXYDEVFBSD)"

Issue #2)
Implement new "usbProxyFreeBSDWakeup" callback function.

Issue #3)
Don't free the private USB data in the USB close function.

Can you get the attached patch into your SVN trunk and send me a 
confirmation back? Thank you!

I see some more issues, which appear to be in the generic VirtualBox USB 
code.


BTW: UASP and USB 3.0 streams mode is somewhat controverisal in some 
circles. Not all USB 3.0 controllers support streams mode, and I think 
that a two pairs of regular BULK endpoints would provide more than 
enough performance for USB mass storage. I don't mind if you leave out 
streams support in VirtualBox ;-)

--HPS


_______________________________________________
vbox-dev mailing list
vbox-dev at virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev