[vbox-dev] What's up with 4.3.8 and VBOX_USE_SYSTEM_XORG_HEADERS=1

[Michael Thayer]

Hello Sérgio,

On 17/03/14 02:44, Sérgio Basto wrote:
[...]
> I'd like communicate my newest patch also to compile guest additions for
> Fedora 19, 20 and 21, only with X11 and Mesa system sources, the patch
> is also available on cvs of rpmfusion [1]
>
> We have some tricks there :
> 1 - ./src/VBox/Additions/common/crOpenGL/fakedri_drv.c have some code
> that depends on internals of X11 source code and that code have been
> removed for X-server 1.15 in Fedora rawhide (21), therefore we couldn't
> compile it. Afterward I found that code is just need to one function :
>      vboxPatchMesaGLAPITable();
> Comment that function and all code that depends on that, make it
> possible (again) compile with system source code and also dropped the
> need of xorg-x11-server-source, now just need "normal" devel packages.

It looks to me as if you are removing the code which sets up the driver 
functionality in Mesa, and I would expect that with this patch you would 
get no hardware accelerated 3D at all (possibly software accelerated 
instead, possibly still reported as hardware accelerated).  Have you 
tested this?  It is usually pretty easy to tell, as you tend to get 
glitches with hardware acceleration when 3D windows (e.g. glxgears) are 
moved, or other windows raised to be on top of them, whereas with 
software acceleration you will not see any glitches.

Regards,

Michael

> 2nd trick is #define HAVE_STRNDUP 1 , I don't understand why is need,
> but is need, for more information, see bug report on freedesktop.org [2]
>
> Other thing that I evaluate, is compile with libXcomposite , libXdamage,
> libXfixes and libXext of the system .
>
> If you could add VBOX_USE_SYSTEM_XORG_HEADERS=1
> for ./src/VBox/Additions/ and other cases will be great.
>
>
> Thanks,
>
> [1]
> http://cvs.rpmfusion.org/viewvc/*checkout*/rpms/VirtualBox/devel/VirtualBox-4.3.6-mesa.patch?root=free&revision=1.3&content-type=text%2Fplain
>
> [2] https://bugs.freedesktop.org/show_bug.cgi?id=47971
>


-- 
ORACLE Deutschland B.V. & Co. KG   Michael Thayer
Werkstrasse 24                     VirtualBox engineering
71384 Weinstadt, Germany           mailto:michael.thayer at oracle.com

Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Geschäftsführer: Jürgen Kunz

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher