[vbox-dev] What's up with 4.3.8 and VBOX_USE_SYSTEM_XORG_HEADERS=1

[Sérgio Basto]

On Qua, 2014-03-12 at 17:19 +0000, Sérgio Basto wrote:
> On Qua, 2014-03-12 at 16:16 +0100, Michael Thayer wrote: 
> > On 12/03/14 15:16, Michael Thayer wrote:
> > > On 07/03/14 18:05, Sérgio Basto wrote:
> > >   > when I try to compile VBOX with VBOX_USE_SYSTEM_XORG_HEADERS=1 , fails
> > >   > on build guests , on Linux Fedora 20 and rawhide .
> > >   > No doubt that you change thing in Linux guests ... also
> > >   > VBOX_USE_SYSTEM_XORG_HEADERS=1 assumes that we have Xorg 7  => xserver
> > >   > 1.1 , when we have xserver 1.15 , so IMHO we can drop support to xserver
> > >   > < 1.6 or 1.8 or 1.10 at least .
> > >
> > > Could you please try this patch?
> > >
> > > Regards,
> > >
> > > Michael
> > >
> > > Index: src/VBox/Additions/x11/vboxvideo/Makefile.kmk
> > > ===================================================================
> > > --- src/VBox/Additions/x11/vboxvideo/Makefile.kmk    (revision 92751)
> > > +++ src/VBox/Additions/x11/vboxvideo/Makefile.kmk    (working copy)
> > > @@ -377,7 +377,7 @@
> > >            /usr/include/libdrm \
> > >            /usr/include/xorg \
> > >            /usr/include/pixman-1
> > > - vboxvideo_drv_system_SOURCES := $(vboxvideo_drv_15_SOURCES)
> > > + vboxvideo_drv_system_SOURCES := $(vboxvideo_drv_17_SOURCES)
> > >    endif
> > 
> > I see someone else has noticed this:
> > 
> > https://www.virtualbox.org/ticket/12803
> 
> 
> Great, many thanks, I will test it tonight, and I will give you
> feedback. 

It works. 
I'd like communicate my newest patch also to compile guest additions for
Fedora 19, 20 and 21, only with X11 and Mesa system sources, the patch
is also available on cvs of rpmfusion [1] 

We have some tricks there :
1 - ./src/VBox/Additions/common/crOpenGL/fakedri_drv.c have some code
that depends on internals of X11 source code and that code have been
removed for X-server 1.15 in Fedora rawhide (21), therefore we couldn't
compile it. Afterward I found that code is just need to one function : 
    vboxPatchMesaGLAPITable(); 
Comment that function and all code that depends on that, make it
possible (again) compile with system source code and also dropped the
need of xorg-x11-server-source, now just need "normal" devel packages.

2nd trick is #define HAVE_STRNDUP 1 , I don't understand why is need,
but is need, for more information, see bug report on freedesktop.org [2]

Other thing that I evaluate, is compile with libXcomposite , libXdamage,
libXfixes and libXext of the system . 

If you could add VBOX_USE_SYSTEM_XORG_HEADERS=1
for ./src/VBox/Additions/ and other cases will be great.


Thanks,

[1]
http://cvs.rpmfusion.org/viewvc/*checkout*/rpms/VirtualBox/devel/VirtualBox-4.3.6-mesa.patch?root=free&revision=1.3&content-type=text%2Fplain

[2] https://bugs.freedesktop.org/show_bug.cgi?id=47971
-- 
Sérgio M. B.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: VirtualBox-4.3.6-mesa.patch
Type: text/x-patch
Size: 7860 bytes
Desc: not available
URL: <http://www.virtualbox.org/pipermail/vbox-dev/attachments/20140317/b5f97b1d/attachment.bin>