[vbox-dev] <PATCH> Minor changes to e1000 device to support Phar Lap ETS

[Jeff Westfahl]

Aleksey,

Unfortunately I found a problem with the WriteRDT part of my patch. 
Further testing with ETS showed that it didn't cover all cases. Here's an 
updated patch that fixes the WriteRDT problem with my previous patch, and 
also sets MDIC_ERROR as previously discussed.

Regards,

Jeff Westfahl

On Wed, 9 Apr 2014, Aleksey Ilyushin wrote:

> Jeff,
>
> No, there is no need. I’ll add MDIC_ERROR to the patch and will apply it.
>
> Many thanks for the patch!
>
> Regards,
> Aleksey
>
> On 07 Apr 2014, at 23:43, Jeff Westfahl <jeff.westfahl at ni.com> wrote:
>
>> Aleksey,
>>
>> Yes, setting MDIC_ERROR in addition to MDIC_READY is probably better
>> behavior. I tested our drivers and they continue to work with both of
>> these bits set, so no complaints about that here.
>>
>> Would you like me to resubmit the patch with this change?
>>
>> Regards,
>>
>> Jeff Westfahl
>>
>> Aleksey Ilyushin <aleksey.ilyushin at oracle.com> wrote on 04/07/2014
>> 02:11:43 PM:
>>
>>> From: Aleksey Ilyushin <aleksey.ilyushin at oracle.com>
>>> To: vbox-dev at virtualbox.org,
>>> Date: 04/07/2014 02:13 PM
>>> Subject: Re: [vbox-dev] <PATCH> Minor changes to e1000 device to support
>> Phar Lap ETS
>>>
>>> Jeff,
>>>
>>> Are you sure there is no need to set MDIC.E bit to indicate an error
>> when the driver attempts to
>>> read/write from non-existing (MDIC.PHYADD != 1) PHY? Your patch merely
>> sets MDIC.R as if the
>>> operation was successful.
>>>
>>> Regards,
>>> Aleksey
>>>
>>>
>>> On 06 Apr 2014, at 06:53, Jeff Westfahl <jeff.westfahl at ni.com> wrote:
>>>
>>>> Here's a patch to the e1000 emulated device that allows it to work
>> with drivers we've written
>>> for Phar Lap ETS, an RTOS we use on some of our products. Please
>> consider this for inclusion in
>>> VirtualBox. I won't claim to have done exhaustive regression testing,
>> but the e1000 driver for a
>>> Windows 7 64-bit VM seems to run just fine with this patch applied. The
>> patch is against 4.3.8
>>> OSE, but applied cleanly to public SVN.
>>>>
>>>> Author: Jeff Westfahl <jeff.westfahl at ni.com>
>>>> License: Patch is under MIT license
>>>>
>>>> Regards,
>>>>
>>>> Jeff
>> Westfahl<e1000patch.diff>_______________________________________________
>>>> vbox-dev mailing list
>>>> vbox-dev at virtualbox.org
>>>> https://www.virtualbox.org/mailman/listinfo/vbox-dev
>>>
>>>
>>> _______________________________________________
>>> vbox-dev mailing list
>>> vbox-dev at virtualbox.org
>>> https://www.virtualbox.org/mailman/listinfo/vbox-dev
>>
>
>
> _______________________________________________
> vbox-dev mailing list
> vbox-dev at virtualbox.org
> https://www.virtualbox.org/mailman/listinfo/vbox-dev
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: e1kpatch.diff
Type: text/x-diff
Size: 1607 bytes
Desc: 
URL: <http://www.virtualbox.org/pipermail/vbox-dev/attachments/20140409/a507a968/attachment.bin>