[vbox-dev] [PATCH] libalias bug

Yohanes Nugroho yohanes at gmail.com
Fri Nov 8 04:27:36 GMT 2013


On Fri, Nov 8, 2013 at 11:16 AM, Yohanes Nugroho <yohanes at gmail.com> wrote:
> Hi,
>
> I have found a bug in libalias, this is a small subtle bug, less than
> should be greater than in the _attach_handler:

In case it cause confusion between my sentence and the patch, the
above sentence was wrong and it should read: "greater than should be
less than".


> Index: src/VBox/Devices/Network/slirp/libalias/alias_mod.c
> ===================================================================
> --- src/VBox/Devices/Network/slirp/libalias/alias_mod.c (revision 49383)
> +++ src/VBox/Devices/Network/slirp/libalias/alias_mod.c (working copy)
> @@ -165,7 +165,7 @@
>              (b->dir == p->dir) &&
>              (b->proto == p->proto))
>              return (EEXIST); /* Priority conflict. */
> -        if (b->pri > p->pri) {
> +        if (b->pri < p->pri) {
>              LIST_INSERT_BEFORE(b, p, entries);
>              return (0);
>          }

-- 
Regards
Yohanes
http://yohan.es/




More information about the vbox-dev mailing list