[vbox-dev] my patches for VirtualBox-4.2.0 on Fedora 17+

[Michael Thayer]

Hello Sérgio,

On 10/02/2012 04:58 PM, Sérgio Basto wrote:
> On Sex, 2012-09-28 at 11:19 +0200, Michael Thayer wrote:
>> On 09/27/2012 10:54 PM, Sérgio Basto wrote:
>> [...]
>>> as a little side note, we have in
>>> VirtualBox-4.2.0/src/VBox/Additions/x11/vboxvideo/Makefile.kmk  :
>>>
>>> vboxvideo_70_DEFS := IN_MODULE XORG_7X RENDER=1 IN_RT_STATIC
>>> vboxvideo_13_DEFS := $(vboxvideo_70_DEFS) VBOXVIDEO_13
>>> vboxvideo_15_DEFS := $(vboxvideo_13_DEFS) VBOX_DRI NO_ANSIC PCIACCESS
>>> XSERVER_LIBPCIACCESS
>>>
>>> vboxvideo_drv_70_DEFS = $(vboxvideo_70_DEFS)
>>> XORG_VERSION_CURRENT=700000000
>>>
>>> vboxvideo_drv_13_DEFS := $(vboxvideo_13_DEFS)
>>> XORG_VERSION_CURRENT=100300000
>>>
>>>
>>> what I mean when I want know what DEFS for vboxvideo_drv_113, I got to
>>> follow all attributions ... and can't comment any ...
[...]
> Hi,
> thanks for reply , sorry I'm little busy here .
> Generally I agree with you , I'm just pointing that you could avoid chains like
>
> a = something
> b = a
> c = b
> d = c
>
> when you may do :
> a = something
> b = a
> c = a
> d = a
Since those definitions are all next to each other anyway it is surely 
not too bad!  In any case, I have applied the patch I posted so that you 
can build with VBOX_USE_SYSTEM_XORG_HEADERS=1 set in future to only 
build the X.Org drivers against the installed system headers.

Regards,

Michael
-- 
ORACLE Deutschland B.V. & Co. KG   Michael Thayer
Werkstrasse 24                     VirtualBox engineering
71384 Weinstadt, Germany           mailto:michael.thayer at oracle.com

Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Geschäftsführer: Jürgen Kunz

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher