[vbox-dev] [PATCH] 64Bit: Driver Signing

[Klaus Espenlaub]

Hi,

while we greatly appreciate contributions which simplify building 
VirtualBox I really wonder what the motivation behind this large 
collection of patches is. Most of them won't be applied ever because 
they would break VirtualBox builds in the setup at Oracle, so I expect 
that we need to discuss about them, especially how they could be done 
without breaking things.

Why do you always go straight for the "Oracle specific" settings instead 
of modifying the places (or adding such if necessary) which should be 
used when people want to build VirtualBox from the public sources?

Cheers,
Klaus

On 12.11.2012 12:56, Bodo wrote:
> adjust tool paths
> tool for retry
>
> ===================================================================
> --- a/Config.kmk	(revision 43841)
> +++ b/Config.kmk	(working copy)
> @@ -2452,8 +2452,8 @@
>       VBOX_PATH_SELFSIGN := $(PATH_DEVTOOLS)/win.x86/selfsign/r1
>      endif
>     endif
> -  VBOX_SIGNTOOL ?= $(PATH_DEVTOOLS)/bin/retry.cmd
> $(VBOX_PATH_SELFSIGN)/SignTool.exe
> -  VBOX_INF2CAT  ?= $(VBOX_PATH_SELFSIGN)/Inf2Cat.exe
> +  VBOX_SIGNTOOL ?= $(PATH_DEVTOOLS)/bin/retry.cmd
> $(PATH_SDK_WINDDK71)/bin/$(KBUILD_TARGET_ARCH)/SignTool.exe
> +  VBOX_INF2CAT  ?= $(PATH_SDK_WINDDK71)/bin/selfsign/Inf2Cat.exe
>
>     # There are three signing modes; 'test', 'development' and 'release'.
>     ifeq ($(strip $(VBOX_SIGNING_MODE)),test)
>
> ===================================================================
> --- a/tools/bin/retry.cmd	(revision 0)
> +++ b/tools/bin/retry.cmd	(working copy)
> @@ -0,0 +1,13 @@
> + at echo off
> +REM
> +REM SignTool.exe Sporadically Fails with Exit Code 1
> +REM
> http://stackoverflow.com/questions/9380751/signtool-exe-sporadically-fails-w
> ith-exit-code-1
> +REM
> +
> + at echo on
> +%*
> + at echo off
> +if %=exitcode% EQU 1 (
> +  @echo on
> +   %*
> +)
> \ No newline at end of file
>
>
> This Patch is contributed under the MIT license
>
> Regards
> Bodo
>
>
> _______________________________________________
> vbox-dev mailing list
> vbox-dev at virtualbox.org
> https://www.virtualbox.org/mailman/listinfo/vbox-dev