[vbox-dev] my patches for VirtualBox-4.2.0 on Fedora 17+

[Michael Thayer]

Hello again,

On 08/12/12 15:18, Michael Thayer wrote:
> Sorry, I haven't forgotten this, but haven't had time to look into
> it yet due to other things I had to take care of.
[...]
> On 03/12/12 19:35, Sérgio Basto wrote:
[...]
>> I want unblundle $(VBOX_PATH_X11_XFREE_4_3)/, if not required have
>> a rule in kmk that doesn't try to build it, would be nice.
The intention was that the lines
   "SYSMODS := $(filter-out vboxvideo_drv%,$(SYSMODS))"
and
   "SYSMODS := $(filter-out vboxmouse_drv%,$(SYSMODS))"
in the src/VBox/Additions/x11/vbox[video|mouse]/Makefile.kmk should do 
just this.  Do they not work as intended?

>>>> http://cvs.rpmfusion.org/viewvc/rpms/VirtualBox/devel/VirtualBox-4.2.0-mesa.patch?revision=1.3&root=free&view=markup
>>>I will take a look at this.
I took a brief look and it probably merits a deeper one (so still not 
forgotten, but still waiting).  Your patch duplicates a few definitions 
and things from Mesa headers inside the source file.  This makes me 
wonder whether we could safely drop the dependency on those headers 
altogether (system or bundled no matter).  Since I didn't write the code 
though I will need to find the time to look at it properly.

>>>> I wonder, If you want permit unbundle some other sources like
>>>> : src/libs/liblzf-3.4/
>>>>
>>>> the : src/libs/boost-1.37.0/ src/libs/libxml2-2.6.31/
>>>> src/libs/libpng-1.2.8/ src/libs/zlib-1.2.6/
>>>>
>>>> I saw that is just used on system that don't have it, and don't
>>>> used on Linux systems.
They aren't used on recent Linux systems, but we also support building 
on older ones.  Here a patch to simply remove them from Fedora's 
distributed version of the source code might make sense if you really 
can't live with it.  Unless we were to take the decision to publish a 
bundle-sanitised second copy of the source (this is just a thought on my 
part, so don't hold your breath waiting for it to happen yet).

Regards,

Michael
-- 
ORACLE Deutschland B.V. & Co. KG   Michael Thayer
Werkstrasse 24                     VirtualBox engineering
71384 Weinstadt, Germany           mailto:michael.thayer at oracle.com

Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Geschäftsführer: Jürgen Kunz

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher